fix sugarscape_g1mt running options, requirements and changes to README #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rht
reviewed
Mar 2, 2024
examples/sugarscape_g1mt/Readme.md
Outdated
| ``` | ||
|
|
||
| Then open your browser to [http://127.0.0.1:8521/](http://127.0.0.1:8521/) and press Reset, then Run. | ||
|
|
||
| ## Files | ||
|
|
||
| * ``sugarscape_g1mt/trader_agents.py``: Defines the Trader agent class. | ||
| * ``sugarscape_g1mt/resource_agents.py``: Defines the Sugar and Spice agent classes. | ||
| * ``sugarscape_g1mt/resource_agents.py``: Defines the Resource agent class which contains an amount of sugar and spice. |
There was a problem hiding this comment.
Those all should be single backticks, since they are Markdown syntax.
rht
reviewed
Mar 2, 2024
examples/sugarscape_g1mt/run.py
Outdated
| @@ -64,42 +64,43 @@ def assess_results(results, single_agent): | |||
|
|
|||
| args = sys.argv[1:] | |||
|
|
|||
|
|
|||
| if args[0] == "runserver": | |||
| try: | |||
There was a problem hiding this comment.
Using a check if len(args) == 0 then server.launch() would reduce the number of nesting by 1. According to PEP 20, flat is better than nested.
for more information, see https://pre-commit.ci
|
LGTM |
|
Merged, thank you @FoFFolo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed the running options on the run.py script according to what the README says, adjusting the option to run "mesa runserver" command.
I also fixed the requirements text file as declared in the issue #76.
I modified the README based on the precedent PRs.
I noticed that there are other problems, especially in the app.py when launching solara, but I don't know if my changes are actually meaningful to merge, so I don't want to do a lot of messy changes.