-
Notifications
You must be signed in to change notification settings - Fork 701
Fix docs build with Hugo v0.128+ by replacing deprecated resources.ToCSS #7270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix docs build with Hugo v0.128+ by replacing deprecated resources.ToCSS #7270
Conversation
Signed-off-by: ShivamJha2436 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7270 +/- ##
=======================================
Coverage 81.05% 81.05%
=======================================
Files 130 130
Lines 19669 19669
=======================================
Hits 15943 15943
Misses 3442 3442
Partials 284 284 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ShivamJha2436, thank you for your contribution!
It looks like the netlify build succeeded even though we’re still using quite an old version defined here:
Line 7 in 31ba99f
| HUGO_VERSION = "0.119.0" |
Would you mind updating that as well?
Signed-off-by: ShivamJha2436 <[email protected]>
After updating to Hugo 0.152.0 with css.Sass, Netlify build fails due to GLIBC errors. We either need to update Netlify’s build image to Ubuntu 22.04+ or revert to the old toCSS pipeline; otherwise, the build won’t work. |
|
Website build failed https://app.netlify.com/projects/projectcontour/deploys/68f7daa245e8a1000805ba77#L95
I think this is because the OS image that netlify uses is old and new hugo binary would require bump to newer distro. Unfortunately I don't have access to our netlify portal to update that 😞 Lets try to revert the hugo version back to original and lets see if the old version handles the |
Oops, sorry I missed your message when responding. |
Signed-off-by: ShivamJha2436 <[email protected]>
|
Hey @tsaarni, could you please approve the workflows when you get a chance? |
What this PR does:
Updates the Contour documentation site to work with Hugo v0.128+ by replacing the deprecated resources.ToCSS function with toCSS. This ensures that contributors using modern Hugo versions can build the docs without errors.
Why this is needed:
With Hugo v0.128 and above, resources.ToCSS was removed. Anyone trying to build the docs with these versions would encounter the following error:
Notes: