Inline makeChild in mint and unroll loop#8
Open
recmo wants to merge 4 commits intoprojectchicago:masterfrom
Open
Inline makeChild in mint and unroll loop#8recmo wants to merge 4 commits intoprojectchicago:masterfrom
recmo wants to merge 4 commits intoprojectchicago:masterfrom
Conversation
recmo
force-pushed
the
optim/unroll-mint
branch
from
6a6dc99 to
3eef040
Compare
recmo
commented
Oct 3, 2018
| makeChild(); | ||
| assembly { | ||
| mstore(0, 0x756eb3f879cb30fe243b4dfee438691c043318585733ff6000526016600af300) | ||
| for {let i := shr(value, 5)} i {i := sub(i, 1)} { |
Author
There was a problem hiding this comment.
shr requires Constantinople. It can be replaced by div(value, 32) for other EVM versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues from PR #7. I think the mint function has no further optimizations that are O(value), unless Solidity does some sub-optimal stack management.
There's another O(value) optimization possible with the trick in #6.