Skip to content

Refind the vcam_s_ext_ctrls #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
weichenli-intel wants to merge 1 commit into from
Closed

Refind the vcam_s_ext_ctrls #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 12 additions & 48 deletions drivers/media/platform/virtio/virtio-camera.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,58 +689,22 @@ static int vcam_s_ctrl(struct file *file, void *fh, struct v4l2_control *control

static int vcam_s_ext_ctrls(struct file *file, void *fh, struct v4l2_ext_controls *controls)
{
struct virtio_camera_video *vnode = video_drvdata(file);
struct virtio_camera_ctrl_req *vcam_req;
struct virtio_camera_mem_entry *ents;
int err;

// Allocate buffer for controls in kernel space
size_t size = sizeof(struct virtio_camera_req_ext_ctrls) +
controls->count * sizeof(struct virtio_camera_req_ctrl);

struct virtio_camera_req_ext_ctrls *ext_ctrls = kmalloc(size, GFP_KERNEL);
if (!ext_ctrls) {
pr_err("virtio-camera: vnode%d fail to alloc ext_ctrls, no mem.\n", vnode->idx);
return -ENOMEM;
}
int err = 0;

// Copy controls data into the allocated buffer
ext_ctrls->count = controls->count;
for (int i = 0; i < controls->count; i++) {
ext_ctrls->controls[i].id = controls->controls[i].id;
ext_ctrls->controls[i].value = controls->controls[i].value;
struct v4l2_control control;
control.id = controls->controls[i].id;
control.value = controls->controls[i].value;

err = vcam_s_ctrl(file, fh, &control);
if (err) {
pr_err("virtio-camera: failed to set control id %d, error: %d\n", control.id, err);
/* You might decide whether to break on the first error or continue trying others */
break; // If you want to abort on first error
// continue; // If you want to attempt setting remaining controls despite errors
}
}

// Create request
vcam_req = virtio_camera_create_req(VIRTIO_CAMERA_CMD_SET_EXT_CTRLS);
if (unlikely(vcam_req == NULL)) {
pr_err("virtio-camera: vnode%d fail to init set_ext_ctrls-req, no mem.\n", vnode->idx);
kfree(ext_ctrls);
return -ENOMEM;
}

// Allocate and initialize virtio_camera_mem_entry
ents = kmalloc(sizeof(struct virtio_camera_mem_entry), GFP_KERNEL);
if (!ents) {
pr_err("virtio-camera: vnode%d fail to alloc ents, no mem.\n", vnode->idx);
kfree(vcam_req);
kfree(ext_ctrls);
return -ENOMEM;
}

ents->addr = (uintptr_t)ext_ctrls; // GPA to HVA conversion will be handled later
ents->length = size;

// Send request
err = vcam_vq_request(vnode, vcam_req, ents, 1, false);
if (err) {
pr_err("virtio-camera: vnode%d set_ext_ctrls failed, err response.\n", vnode->idx);
}

// Clean up resources
kfree(ents);
kfree(vcam_req);
kfree(ext_ctrls);
return err;
}

Expand Down