Camera orientation fails in Portrait mode#12
Open
Sapna1-singh wants to merge 1 commit intoprojectceladon:r/ics3a/mainfrom
Open
Camera orientation fails in Portrait mode#12Sapna1-singh wants to merge 1 commit intoprojectceladon:r/ics3a/mainfrom
Sapna1-singh wants to merge 1 commit intoprojectceladon:r/ics3a/mainfrom
Conversation
When bypass_rotation is enabled and auto-rotate is on, changing camera orientation from landscape to portrait mode fails. Whenever auto-rotate is turned on, windows manager triggers informs camera app to update display and display gets updated. Hwc gets the updated frames and since bypass_rotation is enabled, it performs the rotation again on this. Both bypass_rotation and Auto_rotation can't be applied at the sametime and need to prioritize one of these. Whenever bypass_rotation is enable and auto_rotate is on, prioritize auto_rotate. Tracked-On: OAM-108836 Signed-off-by: Singh, Sapna1 <sapna1.singh@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When bypass_rotation is enabled and auto-rotate is on, changing camera orientation from landscape to portrait mode fails.
Whenever auto-rotate is turned on, windows manager triggers informs camera app to update display and
display gets updated. Hwc gets the updated frames
and since bypass_rotation is enabled, it performs
the rotation again on this.
Both bypass_rotation and Auto_rotation can't be
applied at the sametime and need to prioritize
one of these.
Whenever bypass_rotation is enable and auto_rotate is on, prioritize auto_rotate.
Tracked-On: OAM-108836