Hdcpd 15 by ljia5 · Pull Request #30 · projectceladon/hdcp

ljia5 · 2025-02-05T03:41:37Z

No description provided.

sysopenci · 2025-02-05T03:42:21Z

Program name for this pr is not compatable with other dependent prs, for more details please check tracked_on

sysopenci · 2025-02-05T03:45:23Z

Program name for this pr is not compatable with other dependent prs, for more details please check tracked_on

sysopenci · 2025-02-05T03:48:20Z

Program name for this pr is not compatable with other dependent prs, for more details please check tracked_on

sysopenci · 2025-02-05T08:00:05Z

Program name for this pr is not compatable with other dependent prs, for more details please check tracked_on

sysopenci · 2025-02-06T01:51:22Z

Program name for this pr is not compatable with other dependent prs, for more details please check tracked_on

1. Enable daemon for hdcp1.4/hdcp2.2 2. Add hdcp Test Utility Tracked-On: OAM-130842 Signed-off-by: Jia, Lin A <lin.a.jia@intel.com>

Change to Android.bp for hdcp build Tracked-On: OAM-130842 Signed-off-by: Jia, Lin A <lin.a.jia@intel.com>

Open virtio_gpu drm device for acrn support Tracked-On: OAM-130842 Signed-off-by: Jia, Lin A <lin.a.jia@intel.com>

1. Remove hdcpd srm function due to avoid hdcpd build fail 2. Delete unused build code Tracked-On: OAM-130842 Signed-off-by: Jia, Lin A <lin.a.jia@intel.com>

feijiang1 · 2025-03-13T05:56:19Z

daemon/Android.mk


 LOCAL_CPPFLAGS := \
    -DANDROID \
+    -DUSES_IA_HWCOMPOSER \


why still need use USES_IA_HWCOMPOSER?

feijiang1 · 2025-03-13T05:57:30Z

daemon/portmanager_android.cpp

           {
-	       HDCP_ASSERTMESSAGE("Attempting HDCP Enable");
+	       HDCP_ASSERTMESSAGE("Attempting HDCP Enable, value =%d", value);
+	       HDCP_ASSERTMESSAGE("Attempting HDCP Enable, propValue =%d", propValue);


can combine together as one message

feijiang1 · 2025-03-13T05:57:32Z

daemon/portmanager_android.cpp

               //This is only for HDCP2.2
-	       HDCP_ASSERTMESSAGE("Attempting HDCP Enable Type 1");
+	       HDCP_ASSERTMESSAGE("Attempting HDCP Enable Type, value =%d", value);
+	       HDCP_ASSERTMESSAGE("Attempting HDCP Enable Type, propValue =%d", propValue);


can combine together as one message

feijiang1 · 2025-03-13T05:57:59Z

test/CMakeLists.txt

+# OTHER DEALINGS IN THE SOFTWARE.
+
+
+add_subdirectory(hdcpTestUtility)


why need this?

feijiang1 · 2025-03-13T05:58:22Z

test/hdcpTestUtility/CMakeLists.txt

+
+target_compile_options(${PROJECT_NAME} PRIVATE ${HDCP_CXX_FLAGS})
+
+target_link_libraries(${PROJECT_NAME} hdcpsdk)


it it necessary?

feijiang1 · 2025-03-13T05:59:47Z

test/hdcpTestUtility/hdcpTestUtility.cpp

+{
+    if (nullptr == ctx)
+    {
+        printf("hdcp context pointer is null\n");


If need support both linux and Andorid, we need wrap it, call printf for linux, call LOGD for Android

1. Remove unsed source code 2. Rename USES_IA_HWCOMPOSER define Tracked-On: OAM-130842 Signed-off-by: Jia, Lin A <lin.a.jia@intel.com>

sysopenci · 2025-03-20T05:20:12Z

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

feijiang1

LGTM

sysopenci · 2025-03-20T06:02:38Z

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci · 2025-03-20T06:35:17Z

FAILURE: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci · 2025-03-20T08:11:45Z

SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci · 2025-03-22T05:50:27Z

Android CI has started MERGE Build for this pr ,Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci · 2025-03-22T08:23:27Z

Android CI has completed MERGE Build for this pr, build is FAILURE. Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci · 2025-03-22T08:26:31Z

Android CI has started MERGE Build for this pr ,Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci · 2025-03-22T10:40:07Z

Android CI has completed MERGE Build for this pr, build is FAILURE. Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci · 2025-03-23T18:11:37Z

Android CI has started MERGE Build for this pr ,Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci · 2025-03-23T21:18:16Z

Android CI has completed MERGE Build for this pr, build is SUCCESS. Please check the linked Tracked-On issue/Android CI Web for more details. For Binaries: /cactus-absp-or-local/celadon-merge/1087

sysopenci added the Valid commit message label Feb 5, 2025

sysopenci requested review from JeevakaPrabu, YuanjunHuang, feijiang1, gkdeepa and yaoxinshi-intel February 5, 2025 03:43

sysopenci removed the Valid commit message label Feb 5, 2025

sysopenci added the Valid commit message label Feb 5, 2025

ljia5 force-pushed the hdcpd_15 branch from ca383e3 to 21e9270 Compare March 10, 2025 06:54

sysopenci added Valid commit message and removed Valid commit message labels Mar 10, 2025

ljia5 added 3 commits March 10, 2025 14:09

Enable media hdcp

dec85e6

1. Enable daemon for hdcp1.4/hdcp2.2 2. Add hdcp Test Utility Tracked-On: OAM-130842 Signed-off-by: Jia, Lin A <lin.a.jia@intel.com>

Change hdcpd build method

abcf9ec

Change to Android.bp for hdcp build Tracked-On: OAM-130842 Signed-off-by: Jia, Lin A <lin.a.jia@intel.com>

Add virtio_gpu support for hdcpd

951179d

Open virtio_gpu drm device for acrn support Tracked-On: OAM-130842 Signed-off-by: Jia, Lin A <lin.a.jia@intel.com>

ljia5 force-pushed the hdcpd_15 branch from 21e9270 to 7f54912 Compare March 11, 2025 05:27

sysopenci added Valid commit message and removed Valid commit message labels Mar 11, 2025

Fix hdcpd build fail for android15

7f54912

1. Remove hdcpd srm function due to avoid hdcpd build fail 2. Delete unused build code Tracked-On: OAM-130842 Signed-off-by: Jia, Lin A <lin.a.jia@intel.com>

sysopenci added Valid commit message and removed Valid commit message labels Mar 12, 2025

feijiang1 reviewed Mar 13, 2025

View reviewed changes

daemon/Android.mk Outdated

LOCAL_CPPFLAGS := \

-DANDROID \

-DUSES_IA_HWCOMPOSER \

Copy link

feijiang1 Mar 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why still need use USES_IA_HWCOMPOSER?

feijiang1 reviewed Mar 13, 2025

View reviewed changes

test/CMakeLists.txt Outdated

# OTHER DEALINGS IN THE SOFTWARE.

add_subdirectory(hdcpTestUtility)

Copy link

feijiang1 Mar 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why need this?

feijiang1 reviewed Mar 13, 2025

View reviewed changes

sysopenci added Valid commit message and removed Valid commit message labels Mar 18, 2025

sysopenci requested a review from feijiang1 March 18, 2025 09:14

Refine hdcpd and hdcpTestutily

1378807

1. Remove unsed source code 2. Rename USES_IA_HWCOMPOSER define Tracked-On: OAM-130842 Signed-off-by: Jia, Lin A <lin.a.jia@intel.com>

sysopenci added the Developer Approved label Mar 20, 2025

feijiang1 approved these changes Mar 20, 2025

View reviewed changes

sysopenci added the PR approved label Mar 20, 2025

sysopenci removed request for JeevakaPrabu, YuanjunHuang, gkdeepa and yaoxinshi-intel March 20, 2025 05:24

sysopenci added the Engineering Build Failed label Mar 20, 2025

sysopenci added Engineering Build Successful Engineering Build Successful and removed Engineering Build Failed labels Mar 20, 2025

sysopenci merged commit ccd30e4 into projectceladon:master Mar 23, 2025
14 checks passed

		# OTHER DEALINGS IN THE SOFTWARE.


		add_subdirectory(hdcpTestUtility)


		target_compile_options(${PROJECT_NAME} PRIVATE ${HDCP_CXX_FLAGS})

		target_link_libraries(${PROJECT_NAME} hdcpsdk)

Conversation

ljia5 commented Feb 5, 2025

Uh oh!

sysopenci commented Feb 5, 2025

Uh oh!

sysopenci commented Feb 5, 2025

Uh oh!

sysopenci commented Feb 5, 2025

Uh oh!

sysopenci commented Feb 5, 2025

Uh oh!

sysopenci commented Feb 6, 2025

Uh oh!

feijiang1 Mar 13, 2025

Choose a reason for hiding this comment

Uh oh!

feijiang1 Mar 13, 2025

Choose a reason for hiding this comment

Uh oh!

feijiang1 Mar 13, 2025

Choose a reason for hiding this comment

Uh oh!

feijiang1 Mar 13, 2025

Choose a reason for hiding this comment

Uh oh!

feijiang1 Mar 13, 2025

Choose a reason for hiding this comment

Uh oh!

feijiang1 Mar 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sysopenci commented Mar 20, 2025

Uh oh!

feijiang1 left a comment

Choose a reason for hiding this comment

Uh oh!

sysopenci commented Mar 20, 2025

Uh oh!

sysopenci commented Mar 20, 2025

Uh oh!

sysopenci commented Mar 20, 2025

Uh oh!

sysopenci commented Mar 22, 2025

Uh oh!

sysopenci commented Mar 22, 2025

Uh oh!

sysopenci commented Mar 22, 2025

Uh oh!

sysopenci commented Mar 22, 2025

Uh oh!

sysopenci commented Mar 23, 2025

Uh oh!

Uh oh!

sysopenci commented Mar 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feijiang1 Mar 13, 2025 •

edited

Loading