Wakelock feature for PGP in mwc service#52
Open
shwethabolumbu wants to merge 1 commit intoprojectceladon:mainfrom
Open
Wakelock feature for PGP in mwc service#52shwethabolumbu wants to merge 1 commit intoprojectceladon:mainfrom
shwethabolumbu wants to merge 1 commit intoprojectceladon:mainfrom
Conversation
Signed-off-by: Shwetha B <shwetha.b@intel.com>
lchen43
suggested changes
Dec 21, 2021
| #! /bin/sh | ||
| if adb get-state 1>/dev/null 2>&1 | ||
| then | ||
| state=$(adb shell dumpsys power | grep -oE 'SCREEN_BRIGHT_WAKE_LOCK') |
There was a problem hiding this comment.
better to check if android guest is active.
If no android app/windows is active. We don't need to do the adb check.
Author
There was a problem hiding this comment.
Line 2 checks if guest is active or not using adb.
If not adb, we need to use qemu process for checking the activeness of guest.
shuangwan01
approved these changes
Dec 21, 2021
Contributor
shuangwan01
left a comment
shuangwan01
left a comment
There was a problem hiding this comment.
LGTM. But for integration, the PR needs to be submitted to branch celadon/r/mr0/stable.
Author
|
#53 - New PR in celadon/r/mr0/stable branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shwetha B shwetha.b@intel.com