Repository navigation
feat: add osps baseline - #20
Open
oliverbaehler wants to merge 1 commit into
Open
oliverbaehler wants to merge 1 commit into
oliverbaehler wants to merge 1 commit into
Conversation
Signed-off-by: Oliver Baehler <oliver@sudo-i.net>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new hook blocks commits, and the publishing reference conflicts with the existing SHA-pinning check.
2 open issues
What changed in this PR
Adds OSPS Baseline assessment and publishing automation, alongside GitHub Actions security linting.
Changes:
- Runs baseline assessments and retains results.
- Publishes signed results to grc.store.
- Adds zizmor checks in CI and a local autofix hook.
| File | Description |
|---|---|
prek.toml |
Adds a zizmor commit-message hook. |
.github/workflows/zizmor.yml |
Adds workflow security linting. |
.github/workflows/osps.yml |
Runs baseline scans and uploads results. |
.github/workflows/osps-publish.yml |
Configures scheduled and manual result publishing. |
Review effort: Balanced
| # Keep @v1: grc.store requires refs/tags/v1 in the OIDC signer identity. | ||
| # Do not change this tag or pin it to a commit SHA; publishing will fail. | ||
| # https://github.com/revanite-io/pvtr-publish-results#calling-it | ||
| uses: revanite-io/pvtr-publish-results/.github/workflows/publish.yml@v1 # zizmor: ignore[unpinned-uses] |
| [[repos.hooks]] | ||
| id = "zizmor-fix" | ||
| name = "Security-lint GitHub Actions workflows with zizmor" | ||
| entry = "devbox run -- task lint:zizmor-fix" |
| # Keep @v1: grc.store requires refs/tags/v1 in the OIDC signer identity. | ||
| # Do not change this tag or pin it to a commit SHA; publishing will fail. | ||
| # https://github.com/revanite-io/pvtr-publish-results#calling-it | ||
| uses: revanite-io/pvtr-publish-results/.github/workflows/publish.yml@v1 # zizmor: ignore[unpinned-uses] |
Member
There was a problem hiding this comment.
Seems it's not ignored by the action - https://github.com/projectcapsule/change-windows/actions/runs/39386208888/job/118506549129?pr=20#step:3:44
We need to add this to the zgosalvez/github-actions-ensure-sha-pinned-actions's allowlist
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
=======================================
Coverage 70.25% 70.25%
=======================================
Files 16 16
Lines 1180 1180
=======================================
Hits 829 829
Misses 350 350
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.