Repository navigation
chore: fix headlamp releasing - #18
Merged
Merged
Conversation
Signed-off-by: Oliver Baehler <oliver@sudo-i.net>
Signed-off-by: Oliver Baehler <oliver@sudo-i.net>
Signed-off-by: Oliver Baehler <oliver@sudo-i.net>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
==========================================
- Coverage 70.42% 70.25% -0.18%
==========================================
Files 16 16
Lines 1170 1180 +10
==========================================
+ Hits 824 829 +5
- Misses 345 350 +5
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The shared concurrency group can cancel pending tagged releases before their artifacts are published.
1 open finding
What changed in this PR
Integrates Headlamp packaging into the controller release pipeline, while tightening ChangeWindow identity requirements and expanding Helm configuration.
Changes:
- Builds and packages Headlamp through GoReleaser, then publishes its metadata.
- Requires service accounts for all windows and bundles accounts and permissions with examples.
- Adds Helm schema generation and configurable controller concurrency and API limits.
| File | Description |
|---|---|
| Taskfile.yml | Adds Headlamp release builds and Helm schema checks. |
| playground/README.md | Documents self-contained example bundles. |
| playground/manifests/kustomization.yaml | Removes standalone executor permissions reference. |
| playground/manifests/examples/quickstart.yaml | Bundles a dedicated executor and permissions. |
| playground/manifests/examples/node-pool-maintenance.yaml | Adds the required service account. |
| playground/manifests/examples/maintenance-only.yaml | Adds the required service account. |
| playground/manifests/examples/freeze-except-pods.yaml | Adds the required service account. |
| playground/manifests/examples/executor-rbac.yaml | Removes the separate permissions manifest. |
| playground/manifests/examples/conditional-maintenance.yaml | Adds the required service account. |
| playground/manifests/examples/after-hours.yaml | Bundles executor permissions. |
| playground/manifests/examples/after-hours-executor-rbac.yaml | Removes the separate permissions manifest. |
| playground/manifests/examples/addons_v1alpha1_changewindow.yaml | Bundles a dedicated executor and permissions. |
| playground/manifests/dev/readiness.yaml | Supplies a service-account reference. |
| playground/manifests/demo/window.yaml | Bundles demo executor permissions. |
| internal/testutil/fixtures.go | Adds an identity to shared fixtures. |
| internal/policy/policy.go | Validates service accounts for every window. |
| internal/policy/policy_test.go | Tests identity validation and bundled examples. |
| internal/controller/suite_test.go | Tests service-account schema enforcement. |
| internal/admission/handler_test.go | Tests identity validation on admission. |
| headlamp/src/Details.tsx | Reports missing service accounts. |
| headlamp/README.md | Documents unified release publishing. |
| e2e/wildcard_test.go | Loads the bundled freeze example. |
| e2e/status_test.go | Adds a window identity. |
| e2e/matching_test.go | Updates identities and example loading. |
| e2e/bootstrap_test.go | Adds an infrastructure-guard identity. |
| e2e/after_hours_test.go | Adds a bundled-example loader. |
| docs/layouts/_partials/window-example.html | Handles multi-document example rendering. |
| docs/data/window_example.yaml | Explains required window identities. |
| docs/content/docs/reference/api.md | Updates the generated identity reference. |
| docs/content/docs/guides/security.md | Documents identity migration and bundled permissions. |
| docs/content/docs/getting-started/overview.md | Clarifies admission-only identity requirements. |
| docs/content/docs/getting-started/installation.md | Updates installation and example commands. |
| docs/content/docs/examples/node-pool.md | Documents the bundled identity. |
| docs/content/docs/examples/freeze-except-pods.md | Documents the bundled identity. |
| docs/content/docs/examples/downscale.md | Explains bundled executor permissions. |
| docs/content/docs/examples/deployment-freeze.md | Documents the required identity. |
| docs/content/docs/examples/conditional-changes.md | Documents the bundled identity. |
| docs/content/docs/examples/after-hours.md | Explains bundled executor permissions. |
| docs/content/docs/examples/_index.md | Introduces self-contained example bundles. |
| docs/content/docs/development/playground.md | Explains demo and example packaging. |
| DEVELOPMENT.md | Documents Helm schema generation. |
| devbox.lock | Locks the Helm schema plugin. |
| devbox.json | Configures the Helm schema plugin. |
| cmd/main.go | Adds worker and API-rate flags. |
| charts/change-windows/values.yaml | Adds controller settings and schema annotations. |
| charts/change-windows/values.schema.json | Adds generated values validation. |
| charts/change-windows/templates/deployment.yaml | Passes controller tuning flags. |
| charts/change-windows/README.md | Documents controller tuning values. |
| charts/change-windows/crds/addons.projectcapsule.dev_changewindows.yaml | Requires and validates service-account references. |
| api/v1alpha1/changewindow_types.go | Defines required identity validation. |
| .goreleaser.yml | Builds and archives Headlamp. |
| .github/workflows/releaser.yml | Combines release and metadata publication. |
| .github/workflows/releaser-dry-run.yml | Includes Headlamp changes in release checks. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
bakito
self-requested a review
October 15, 2026 09:16
bakito
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.