fix(form-builder): don't evaluate option isHidden jexl in form-builder

projectcaluma · Jan 30, 2025 · 88a9306 · 88a9306
1 parent d5ef8e3
commit 88a9306
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/packages/form-builder/addon/components/cfb-form-editor/question/default.hbs b/packages/form-builder/addon/components/cfb-form-editor/question/default.hbs
@@ -1,6 +1,8 @@
 <div class="uk-margin">
   <@labelComponent />
 
+  {{! Default values for ChoiceQuestions and MultipleChoiceQuestion options are not updated
+  when a new one is added because the object returned by `this.field` is too nested to track properly. }}
   <div class="uk-form-controls">
     {{component
       (get-widget this.field.question)

diff --git a/packages/form-builder/addon/components/cfb-form-editor/question/default.js b/packages/form-builder/addon/components/cfb-form-editor/question/default.js
@@ -45,7 +45,16 @@ export default class CfbFormEditorQuestionDefault extends Component {
       // Format option changesets to match the raw format needed in lib.
       raw[key] = {
         edges: raw.options.map((node) => {
-          return { node };
+          return {
+            node: {
+              ...node.get("data"),
+              ...node.get("change"),
+              // While we want the real value of the option, the option should never
+              // be hidden in the form-builder. We need to set a value here as no
+              // value will lead to a Jexl error.
+              isHidden: "false",
+            },
+          };
         }),
       };
       delete raw.options;

diff --git a/packages/form-builder/translations/it.yaml b/packages/form-builder/translations/it.yaml
@@ -144,6 +144,7 @@ caluma:
       delete: "Elimina opzione"
       archive: "Archivia (nascondi) opzione"
       restore: "Ripristina opzione"
+      show-jexl: "Mostra JEXL"
 
     notification:
       form: