Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the calico-go-build container build to use AlmaLinux 8 as the base OS image (instead of UBI8), simplifying repo setup by relying on Alma’s native repositories.
Changes:
- Switch the go-build Dockerfile base stage from
registry.access.redhat.com/ubi8/ubi:latesttoalmalinux:8. - Consolidate system dependency installation into a single
dnfinstall step withpowertoolsenabled. - Remove now-unneeded AlmaLinux
.repofiles and the AlmaLinux RPM GPG key from the image build context.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| images/calico-go-build/Dockerfile | Moves go-build base to AlmaLinux 8 and updates dependency install flow; final scratch stage now copies from builder. |
| images/calico-go-build/almalinux/almalinux.repo | Deleted; previously provided Alma BaseOS repo config for UBI-based builds. |
| images/calico-go-build/almalinux/almalinux-appstream.repo | Deleted; previously provided Alma AppStream repo config for UBI-based builds. |
| images/calico-go-build/almalinux/almalinux-powertools.repo | Deleted; previously provided Alma PowerTools repo config for UBI-based builds. |
| images/calico-go-build/almalinux/RPM-GPG-KEY-AlmaLinux | Deleted; previously provided AlmaLinux GPG key for the custom repo setup. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.