Open
Conversation
mazdakn
added
docs-not-required
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the BPF (Berkeley Packet Filter) dataplane to store DSCP (Differentiated Services Code Point) values in connection tracking entries instead of using a separate cluster external flag. The change aims to improve QoS (Quality of Service) handling by directly associating DSCP values with connection tracking state.
Key changes:
- Removes the
CALI_ST_CLUSTER_EXTERNALflag andFlagClusterExternalfrom conntrack - Adds DSCP field to conntrack structures and creates DSCP values directly in conntrack entries
- Updates test expectations to remove cluster external flag assertions
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| felix/bpf/ut/nat_test.go | Updates test expectations to remove FlagClusterExternal assertions |
| felix/bpf/ut/icmp_too_big_test.go | Updates test expectations to remove FlagClusterExternal assertion |
| felix/bpf/conntrack/v3/map.go | Removes FlagClusterExternal constant definition |
| felix/bpf-gpl/types.h | Removes CALI_ST_CLUSTER_EXTERNAL flag definition |
| felix/bpf-gpl/tc.c | Replaces cluster external flag logic with direct DSCP assignment |
| felix/bpf-gpl/qos.h | Removes qos_dscp_needs_update function and simplifies DSCP logic |
| felix/bpf-gpl/conntrack_types.h | Adds dscp field to conntrack structures and removes cluster external flag |
| felix/bpf-gpl/conntrack.h | Updates conntrack creation to include DSCP values |
Contributor
|
This PR is stale because it has been open for 60 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.