Skip to content

Rename QoS policy manager to DSCP manager to avoid confusion#10869

Merged
mazdakn merged 2 commits intoprojectcalico:masterfrom
mazdakn:dscp-manager
Aug 22, 2025
Merged

Rename QoS policy manager to DSCP manager to avoid confusion#10869
mazdakn merged 2 commits intoprojectcalico:masterfrom
mazdakn:dscp-manager

Conversation

@mazdakn
Copy link
Member

@mazdakn mazdakn commented Aug 22, 2025

Description

Rename qos to dscp in file names, variables, types, etc made in the following two PRs, to avoid confusion as feature is all about setting DSCP:

Related issues/PRs

Todos

  • Tests
  • Documentation
  • Release note

Release Note

TBD

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

  • docs-pr-required: This change requires a change to the documentation that has not been completed yet.
  • docs-completed: This change has all necessary documentation completed.
  • docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

  • release-note-required: This PR has user-facing changes. Most PRs should have this label.
  • release-note-not-required: This PR has no user-facing changes.

Other optional labels:

  • cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
  • needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

Copilot AI review requested due to automatic review settings August 22, 2025 16:49
@mazdakn mazdakn requested a review from a team as a code owner August 22, 2025 16:49
@mazdakn mazdakn added docs-not-required Docs not required for this change release-note-not-required Change has no user-facing impact labels Aug 22, 2025
@marvin-tigera marvin-tigera added this to the Calico v3.31.0 milestone Aug 22, 2025

This comment was marked as outdated.

@mazdakn mazdakn requested a review from Copilot August 22, 2025 16:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames QoS policy manager to DSCP manager to better reflect the feature's purpose of setting Differentiated Services Code Point (DSCP) values rather than generic Quality of Service policies.

  • Renames types, variables, and functions from "qos"/"QoS" to "dscp"/"DSCP" throughout the codebase
  • Updates chain names and test descriptions to reflect the more specific DSCP functionality
  • Maintains the same functionality while providing clearer naming conventions

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
felix/rules/static_test.go Updates test expectations to use new DSCP chain name
felix/rules/static.go Changes chain target from QoS policy to egress DSCP
felix/rules/rule_defs.go Renames chain constant and method signature from QoS to DSCP
felix/rules/dscp_test.go Updates test descriptions and variable names from QoS to DSCP
felix/rules/dscp.go Renames type and method from QoSPolicy to DSCPRule with updated field names
felix/fv/dscp_test.go Updates functional test descriptions and chain name references
felix/dataplane/linux/int_dataplane.go Changes manager instantiation from QoS policy to DSCP manager
felix/dataplane/linux/dscp_mgr_test.go Updates test descriptions and variable names throughout
felix/dataplane/linux/dscp_mgr.go Renames manager type and updates all QoS references to DSCP

@mazdakn mazdakn changed the title Rename QoS policy manager to DSCP manager to avoid confustion Rename QoS policy manager to DSCP manager to avoid confusion Aug 22, 2025
@mazdakn mazdakn merged commit 50f07eb into projectcalico:master Aug 22, 2025
5 of 6 checks passed
@mazdakn mazdakn deleted the dscp-manager branch August 22, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-not-required Docs not required for this change release-note-not-required Change has no user-facing impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants