Rename QoS policy manager to DSCP manager to avoid confusion#10869
Merged
mazdakn merged 2 commits intoprojectcalico:masterfrom Aug 22, 2025
Merged
Rename QoS policy manager to DSCP manager to avoid confusion#10869mazdakn merged 2 commits intoprojectcalico:masterfrom
mazdakn merged 2 commits intoprojectcalico:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR renames QoS policy manager to DSCP manager to better reflect the feature's purpose of setting Differentiated Services Code Point (DSCP) values rather than generic Quality of Service policies.
- Renames types, variables, and functions from "qos"/"QoS" to "dscp"/"DSCP" throughout the codebase
- Updates chain names and test descriptions to reflect the more specific DSCP functionality
- Maintains the same functionality while providing clearer naming conventions
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| felix/rules/static_test.go | Updates test expectations to use new DSCP chain name |
| felix/rules/static.go | Changes chain target from QoS policy to egress DSCP |
| felix/rules/rule_defs.go | Renames chain constant and method signature from QoS to DSCP |
| felix/rules/dscp_test.go | Updates test descriptions and variable names from QoS to DSCP |
| felix/rules/dscp.go | Renames type and method from QoSPolicy to DSCPRule with updated field names |
| felix/fv/dscp_test.go | Updates functional test descriptions and chain name references |
| felix/dataplane/linux/int_dataplane.go | Changes manager instantiation from QoS policy to DSCP manager |
| felix/dataplane/linux/dscp_mgr_test.go | Updates test descriptions and variable names throughout |
| felix/dataplane/linux/dscp_mgr.go | Renames manager type and updates all QoS references to DSCP |
sridhartigera
approved these changes
Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rename
qostodscpin file names, variables, types, etc made in the following two PRs, to avoid confusion as feature is all about setting DSCP:Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.