Allow changing extenal client image in Felix FVs#10742
Merged
mazdakn merged 1 commit intoprojectcalico:masterfrom Jul 30, 2025
Merged
Allow changing extenal client image in Felix FVs#10742mazdakn merged 1 commit intoprojectcalico:masterfrom
mazdakn merged 1 commit intoprojectcalico:masterfrom
Conversation
mazdakn
added
the
release-note-required
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables custom Docker images for external client containers in Felix Functional Verification (FV) tests. By default, these tests use a busybox image, but this change allows specifying alternative images like calico node which includes additional tools such as iptables.
Key changes:
- Adds an
Imagefield toExtClientOptsstruct for specifying custom container images - Updates
RunExtClientWithOptsfunction to use the custom image when provided, falling back to the defaultbusyboximage
mazdakn
force-pushed
the
set-extclient-image
branch
from
a2f3384 to
3bb4cae
Compare
mazdakn
added
release-note-not-required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
By default, Felix FVs use
busyboximage for external client container. However, in some cases, it's desirable to use another one. As an example, in this PR, I need to add iptables rules to external client container to drop packets based on DSCP value. However,busyboximage does not contain iptables by default. Instead, it's possible to usecalico nodeimage for the external client since it already include iptables binary.Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.