[QoS controls] upgrade bandwidth QoS logging to Warn, but rate-limit to one message every 5 min#10566
Draft
coutinhop wants to merge 1 commit intoprojectcalico:masterfrom
Draft
[QoS controls] upgrade bandwidth QoS logging to Warn, but rate-limit to one message every 5 min#10566coutinhop wants to merge 1 commit intoprojectcalico:masterfrom
coutinhop wants to merge 1 commit intoprojectcalico:masterfrom
Conversation
…to one message every 5 min
coutinhop
added
docs-not-required
Contributor
|
This PR is stale because it has been open for 60 days with no activity. |
Contributor
|
This PR is stale because it has been open for 60 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Any errors when configuring bandwidth QoS controls (e.g. invalid values, missing mandatory annotations, etc) would be logged only at
debuglevel. This is good because it would potentially happen on every workload endpoint update for the problem pods, but it also means there is no visibility of those errors to the user unless they enabledebuglogging. By switching the level towarn, the errors would be more visible, but this could be very spammy, so applying a rate-limiter of one message every 5 minutes mitigates the spammyness.Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.