Windows: felix config natExclusions for host net#10357
Open
wayne-cheng wants to merge 1 commit intoprojectcalico:masterfrom
Open
Windows: felix config natExclusions for host net#10357wayne-cheng wants to merge 1 commit intoprojectcalico:masterfrom
wayne-cheng wants to merge 1 commit intoprojectcalico:masterfrom
Conversation
Contributor
|
This PR is stale because it has been open for 60 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Due to the addition of the Felix config
natOutgoingExclusions, I need to adapt it on Windows. Since theIPIPmode cannot be used on Windows, and it is also impossible to query ipset (both are features of Linux), the implementationIPPoolsAndHostIPsof the confignatOutgoingExclusionson Windows is just to exclude the subnet of the HNS management network.Related issues/PRs
follow-up #8961, this fixes Windows part of #8960
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.