Add timeout to k8s backend client#10190
Open
takmatsu wants to merge 1 commit intoprojectcalico:masterfrom
Open
Add timeout to k8s backend client#10190takmatsu wants to merge 1 commit intoprojectcalico:masterfrom
takmatsu wants to merge 1 commit intoprojectcalico:masterfrom
Conversation
marvin-tigera
added
release-note-required
|
|
caseydavenport
added
docs-not-required
Member
|
@takmatsu thanks for the PR! You'll need to sign the CLA in order to make the bot happy |
takmatsu
force-pushed
the
add-timeout-kubeclient
branch
from
a057c5b to
5cde8b5
Compare
Contributor
|
This PR is stale because it has been open for 60 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, k8s backend client doesn't have timeout, which causes long waiting connection could be happened when kube-api becomes unstable like network issue or node is replaced.
This PR adds timeout to kubernetes client config and make possible to reconnect correctly.
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.