-
Notifications
You must be signed in to change notification settings - Fork 254
Backport unpermitted params #2718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
geoblacklight/master outputs a lot of:
as intended. |
blacklight_oai_provider outputs a lot of:
as intended. |
blacklight_range_limit/master has been updated to register the params; the last released version (v8.1.0) passes CI against the branch with:
|
spotlight/master a bit harder to test because there are 2 or 3 (depending on ruby 3 or 2.7) expected unrelated failures (see #2816). I am seeing a lot of:
|
By way of review I've also drafted a PR to blacklight_range_limit following this pattern: projectblacklight/blacklight_range_limit#186 Running locally with solr_wrapper pinned to 8.9.0 and using this branch of blacklight 7, it is passing. |
I also note that range limit and spotlight are both getting deprecation warnings for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested against the last release tags of the plugins I know about, and things are working as expected. I can see it's a bit of a drag to get the merge working on permitted params, but I think the approach here is strictly an improvement.
Backport of #2717.
To maintain backwards compatibility, defaults
blacklight_config.filter_search_state_fields
tofalse
, which means we only warn about the parameters instead of filtering them out. This gives plugins and downstream apps a chance to add eitherpermitted_params
for a custom FilterField, or add configuration tosearch_state_fields
.