Extract FeaturedAuthor management into dedicated controllers #957

Copilot · 2026-01-28T18:34:02Z

Extract FeaturedAuthor Management to Separate Controllers

This PR extracts FeaturedAuthor management code from AdminController into dedicated controllers, following the same pattern already established for FeaturedContent.

Summary of Changes

Created new controllers:
- Admin::FeaturedAuthorsController - handles CRUD operations for FeaturedAuthor records
- Admin::FeaturedAuthorFeaturesController - manages feature date ranges
Updated routes:
- Changed from custom routes to RESTful resource notation
- Nested features routes under featured_authors
Created new views:
- Moved views from app/views/admin/featured_author_* to app/views/admin/featured_authors/
- Updated views to use RESTful path helpers
- Improved form using Rails conventions and safe navigation
- Deleted old legacy templates
Added model validations:
- FeaturedAuthor now validates presence of title and body
- FeaturedAuthorFeature validates presence of fromdate and todate
- Made person association optional to handle legacy data
Created comprehensive tests:
- Full controller specs for both new controllers
- Tests cover CRUD operations, validations, and error handling
Removed legacy code:
- Removed all featured_author methods from AdminController
- Removed corresponding tests from AdminController spec

Code Review Improvements

Fixed edit link in index view to use correct path helper
Fixed CSS typo (alignment → text-align)
Made flash handling consistent across all actions
Changed destroy! to destroy for graceful error handling
Made person association optional to handle legacy data
Fixed test parameter names to match implementation
Fixed person_id handling to use strong params consistently in both create and update
Removed old legacy view templates

Plan

Original prompt

This section details on the original issue you should resolve

<issue_title>Extract FeaturedAuthor management code into a separate controller</issue_title>
<issue_description>We have bunch of actions in AdminController to handle FeaturedAuthor records:
  get 'admin/featured_author_list'
  get 'admin/featured_author/new' => 'admin#featured_author_new', as: 'featured_author_new'
  post 'admin/featured_author/create' => 'admin#featured_author_create', as: 'featured_author_create'
  get 'admin/featured_author/edit/:id' => 'admin#featured_author_edit', as: 'featured_author_edit'
  patch 'admin/featured_author/update' => 'admin#featured_author_update', as: 'featured_author_update'
  get 'admin/featured_author/destroy/:id' => 'admin#featured_author_destroy', as: 'featured_author_destroy'
  post 'admin/featured_author/add_feature' => 'admin#featured_author_add_feature', as: 'featured_author_add_feature'
  get 'admin/featured_author/delete_feature/:id' => 'admin#featured_author_delete_feature', as: 'featured_author_delete_feature'
  get 'admin/featured_author/:id' => 'admin#featured_author_show', as: 'featured_author_show'
It would be better to extract this logic into a separate controller FeaturedAuthorsController (and functionality to create feature records into FeaturedAuthorFeaturesController).

With this we can use resource notation in routes.rb like
resources :featured_author do
  member do
    resources :features, only [:create, :delete]
  end
end
```</issue_description>

## Comments on the Issue (you are @copilot in this section)

<comments>
</comments>

Fixes Extract FeaturedAuthor management code into a separate controller #360

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: abartov <[email protected]>

github-actions · 2026-01-29T19:17:18Z

app/controllers/admin/featured_author_features_controller.rb

+    private
+
+    def featured_author_feature_params
+      params.require(:featured_author_feature).permit(:fromdate, :todate)


Rails/StrongParametersExpect: Use expect(featured_author_feature: [:fromdate, :todate]) instead.

Copilot

Pull request overview

Extracts FeaturedAuthor management out of AdminController into dedicated admin controllers, aligning the implementation with the existing “FeaturedContent” pattern and switching to RESTful routes/views.

Changes:

Added Admin::FeaturedAuthorsController (CRUD) and Admin::FeaturedAuthorFeaturesController (feature period management) with new controller specs.
Replaced legacy custom routes with RESTful resources routes and updated admin navigation accordingly.
Added model validations and i18n keys to support failure messaging for feature period creation.

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
spec/controllers/admin_controller_spec.rb	Removes legacy FeaturedAuthor specs tied to `AdminController` actions.
spec/controllers/admin/featured_authors_controller_spec.rb	Adds controller specs for FeaturedAuthor CRUD.
spec/controllers/admin/featured_author_features_controller_spec.rb	Adds controller specs for creating/deleting feature periods.
config/routes.rb	Adds RESTful admin routes for featured authors/features and removes legacy custom routes.
config/locales/he.yml	Adds i18n key for featured-author feature creation failure.
config/locales/en.yml	Adds i18n key for featured-author feature creation failure.
app/views/admin/index.html.haml	Updates admin dashboard link to the new RESTful FeaturedAuthors index.
app/views/admin/featured_authors/show.html.haml	New admin show page for FeaturedAuthor + feature period management UI.
app/views/admin/featured_authors/index.html.haml	New admin index for FeaturedAuthors using RESTful path helpers.
app/views/admin/featured_authors/new.html.haml	New admin “new featured author” page using shared form partial.
app/views/admin/featured_authors/edit.html.haml	New admin “edit featured author” page using shared form partial.
app/views/admin/featured_authors/_form.html.haml	New shared form partial (title/body + linked author autocomplete).
app/models/featured_author.rb	Makes `person` optional and adds presence validations for `title`/`body`.
app/models/featured_author_feature.rb	Adds presence validations for `fromdate`/`todate`.
app/controllers/admin_controller.rb	Removes legacy FeaturedAuthor actions and strong params helper.
app/controllers/admin/featured_authors_controller.rb	New RESTful controller for FeaturedAuthor CRUD.
app/controllers/admin/featured_author_features_controller.rb	New controller for creating/destroying FeaturedAuthorFeature records.

Copilot · 2026-01-29T19:35:51Z

app/controllers/admin/featured_authors_controller.rb

+    def create
+      @fc = FeaturedAuthor.new(fa_params)
+      @fc.person_id = params[:person_id]
+      @fc.user = current_user


person_id is being passed as a top-level param and manually assigned in create, but update never applies params[:person_id]. As a result, changing the linked author in the edit form won’t persist (the UI posts person_id, but the controller ignores it). Consider accepting person_id via strong params (e.g., include it in fa_params) and updating both create and update to use it consistently.

Fixed in commit 185d2e4. Added person_id to strong params (fa_params) so both create and update actions now handle the linked author consistently.

app/views/admin/featured_authors/_form.html.haml

Copilot · 2026-01-29T19:35:52Z

config/routes.rb

+    resources :featured_authors do
+      resources :features, controller: 'featured_author_features', only: %i(create)
+    end
+    resources :featured_author_features, only: %i(destroy)


PR description says the old app/views/admin/featured_author_* templates were moved to app/views/admin/featured_authors/, but the legacy templates still exist in the repo and reference the removed admin#featured_author_* routes. Consider deleting the unused templates (and any related partials) to avoid dead code and future confusion.

Fixed in commit 185d2e4. Deleted all old legacy templates:

app/views/admin/featured_author_edit.html.haml

app/views/admin/featured_author_list.html.haml

app/views/admin/featured_author_new.html.haml

app/views/admin/featured_author_show.html.haml

app/views/admin/_featured_author_form.html.haml

Co-authored-by: Copilot <[email protected]>

abartov · 2026-01-29T19:38:28Z

@copilot -- address the code review comments.

- Include person_id in strong params for both create and update actions - Update test to pass person_id inside featured_author params - Delete old legacy view templates that are no longer used Co-authored-by: abartov <[email protected]>

Initial plan

70dfab4

Copilot AI assigned Copilot and abartov Jan 28, 2026

Copilot started work on behalf of abartov January 28, 2026 18:34 View session

Copilot AI and others added 4 commits January 28, 2026 18:41

Extract FeaturedAuthor management to separate controllers

6cab064

Co-authored-by: abartov <[email protected]>

Add validations and fix linting issues

af48bfc

Co-authored-by: abartov <[email protected]>

Remove old featured_author tests from AdminController spec

33f8adb

Co-authored-by: abartov <[email protected]>

Address code review feedback

efb3cd8

Co-authored-by: abartov <[email protected]>

Copilot AI changed the title ~~[WIP] Extract FeaturedAuthor management code into separate controller~~ Extract FeaturedAuthor management into dedicated controllers Jan 28, 2026

Copilot AI requested a review from abartov January 28, 2026 19:03

Copilot finished work on behalf of abartov January 28, 2026 19:03

Merge branch 'master' into copilot/extract-featured-author-controller

38b7513

github-actions bot reviewed Jan 29, 2026

View reviewed changes

abartov requested a review from Copilot January 29, 2026 19:21

Copilot started reviewing on behalf of abartov January 29, 2026 19:22 View session

Merge branch 'master' into copilot/extract-featured-author-controller

2abdbe6

Copilot AI reviewed Jan 29, 2026

View reviewed changes

Update app/views/admin/featured_authors/_form.html.haml

3239b76

Co-authored-by: Copilot <[email protected]>

Copilot started work on behalf of abartov January 29, 2026 19:39 View session

Copilot finished work on behalf of abartov January 29, 2026 19:45

abartov marked this pull request as ready for review January 29, 2026 20:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extract FeaturedAuthor management into dedicated controllers #957

Extract FeaturedAuthor management into dedicated controllers #957

Uh oh!

Copilot AI commented Jan 28, 2026 •

edited

Loading

Uh oh!

github-actions bot Jan 29, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 29, 2026

Uh oh!

Copilot AI Jan 29, 2026

Uh oh!

Uh oh!

Copilot AI Jan 29, 2026

Uh oh!

Copilot AI Jan 29, 2026

Uh oh!

abartov commented Jan 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Extract FeaturedAuthor management into dedicated controllers #957

Are you sure you want to change the base?

Extract FeaturedAuthor management into dedicated controllers #957

Uh oh!

Conversation

Copilot AI commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Extract FeaturedAuthor Management to Separate Controllers

Summary of Changes

Code Review Improvements

Plan

Uh oh!

github-actions bot Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

abartov commented Jan 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Jan 28, 2026 •

edited

Loading