Skip to content

Load presets and play them with playlist #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 19 commits into
base: clang-format
Choose a base branch
from

Conversation

revmischa
Copy link
Contributor

Support playing presets provided by the user

@hack-s
Copy link
Contributor

hack-s commented Jul 6, 2024

is the .idea folder being added intentionally ? I would usually not commit the IDE project files..

@revmischa
Copy link
Contributor Author

is the .idea folder being added intentionally ? I would usually not commit the IDE project files..

It was intentional, the cmake settings and target apply to anyone using intellij

@blaquewithaq
Copy link
Contributor

I'd like the playlist feature to be optional as well. Because I do not use the playlists feature.

I tested this and it wouldn't work with my current setup so had to go back to master branch.

@revmischa
Copy link
Contributor Author

I'd like the playlist feature to be optional as well. Because I do not use the playlists feature.

I tested this and it wouldn't work with my current setup so had to go back to master branch.

It is an option now, it's on by default, did you try adding shuffle-presets=false?

@blaquewithaq
Copy link
Contributor

I'd like the playlist feature to be optional as well. Because I do not use the playlists feature.
I tested this and it wouldn't work with my current setup so had to go back to master branch.

It is an option now, it's on by default, did you try adding shuffle-presets=false?

I'd like the playlist feature to be optional as well. Because I do not use the playlists feature.
I tested this and it wouldn't work with my current setup so had to go back to master branch.

It is an option now, it's on by default, did you try adding shuffle-presets=false?

Shuffling presets has to do with randomly selecting presets.

There should be an option: enable-playlist, added that disables/enables the ENTIRE feature.

@kblaschke
Copy link
Member

The playlist headers need an update, we should release v4.1.5 and wait for Homebrew to update the formula. Then the build will pass.

@revmischa revmischa changed the base branch from master to clang-format April 5, 2025 03:39
@revmischa revmischa requested review from hack-s and blaquewithaq April 5, 2025 05:07
@revmischa
Copy link
Contributor Author

I'd like the playlist feature to be optional as well. Because I do not use the playlists feature.
I tested this and it wouldn't work with my current setup so had to go back to master branch.

It is an option now, it's on by default, did you try adding shuffle-presets=false?

I'd like the playlist feature to be optional as well. Because I do not use the playlists feature.
I tested this and it wouldn't work with my current setup so had to go back to master branch.

It is an option now, it's on by default, did you try adding shuffle-presets=false?

Shuffling presets has to do with randomly selecting presets.

There should be an option: enable-playlist, added that disables/enables the ENTIRE feature.

Okay I've added enable-playlist!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants