Swap UI: Fixed input bug due to locale differences#76
Open
hesido wants to merge 2 commits intoproject-serum:masterfrom
Open
Swap UI: Fixed input bug due to locale differences#76hesido wants to merge 2 commits intoproject-serum:masterfrom
hesido wants to merge 2 commits intoproject-serum:masterfrom
Conversation
Inputs allow locale dependent entry Negative inputs are denied
Author
|
There was a problem with the inputs being impossible on different locales that does not use "." as the decimal separator. After some investigation, I realized the issue stemmed from trying to parseFloat the string input as the values entered were first converted into a string according to the local, but they could not be converted back to a number for locales that use ",". However, some work needs to be done before merging this, as parsefloat has precision problems. The conversion to string hid this, but internally, the precision is already lost when using float numbers. |
Amounts use Big number type Locale independent entry Inputs are decoupled from amounts
Author
|
In this second commit for the pull request, I have fixed some useability problems in the Swap UI:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inputs allow locale dependent entry
Negative inputs are denied