Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NCL-8275] Allow page size of 0 #4070

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[NCL-8275] Allow page size of 0 #4070

wants to merge 1 commit into from

Conversation

patrikk0123
Copy link
Contributor

@patrikk0123 patrikk0123 commented Aug 21, 2024 •
edited
Loading

Checklist:

  • Have you added unit tests for your change?

janinko
janinko requested changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@janinko janinko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests that test that the page size 0 works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janinko janinko Awaiting requested review from janinko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patrikk0123 @janinko