Remove redundant edittext_login_id

[oja]

The value of edittext_login_id can be calculated from the value of edittext_login_username, so it is not needed.

[ehsanmasdar]

Student id is used to select a student for multi student parent accounts, which could not be parsed in this way

[patil215]

Yep, what @ehsanmasdar said is accurate. Unless TEAMS has changed, you can't do what this pull request is suggesting, since there are certain accounts where there are multiple student IDs tied to one username.

If you really want to remove the student ID box, one option is to have an additional spinner style selection prompt pop up if the parser detects multiple student IDs in the account when logging in.

[oja]

I've seen a couple of students get confused about providing the same information twice on login, so I think its probably best to remove the third box.

In order to cover the case of multistudent accounts @ehsanmasdar brought up: maybe there could be a prompt for that information after clicking the login button (similar to the existing "secondary login" one)? Or do you think the whole thing should be left as-is?

[patil215]

Yep, the secondary prompt is exactly what I suggested above - I think that'd definitely be a great improvement over the current implementation.

[oja]

Sorry, didn't see your edit to that comment.