Open
Conversation
Author
|
@azaroth42 my commit removed the edits from base and created a BNF Loader. it's a little complicated, because several of the BNF files store records both in "#about" and without the about. so there's duplicate identifiers, and records split in two. this should work for both cases: when there's just one identifier (the rameau SH file), and when there's duplicates/two records (geos, people & groups). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
not a BNF loader, actually.
new file: external documentation markdown.
edited:
base loader for initial functionality with BNF & FAST XML files. will need further testing with BNF as that regex might not work consistently with all of the BNF files. I can keep at that, but wanted to get something initial in before I went too far down the path.
task ui manager was missing an OS import
download manager missing a logging import
removed call to oldDNBLoader from dnbloader as it doesn't exist