Replace copied SparseAnalysis with MLIR adapter#555
Merged
iangneal merged 5 commits intoJun 23, 2026
Conversation
Kuhai9801
force-pushed
the
issue-308-sparse-adapter-ci
branch
from
e213bc2 to
d9f8da9
Compare
Kuhai9801
force-pushed
the
issue-308-sparse-adapter-ci
branch
from
1610380 to
d20173c
Compare
iangneal
requested changes
Jun 22, 2026
iangneal
left a comment
iangneal
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the contribution! Overall this LGTM, I just have a few nits.
iangneal
approved these changes
Jun 23, 2026
iangneal
left a comment
iangneal
left a comment
Contributor
There was a problem hiding this comment.
LGTM---thank you for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #308.
This removes LLZK's copied sparse data-flow implementation and replaces it with a small adapter over upstream MLIR sparse analysis.
The adapter preserves LLZK's required handling for live zero-result operations, including operand subscriptions, external zero-result calls, and interprocedural zero-result call behavior.
Added focused unit coverage for zero-result operation revisits, program-order initialization, liveness, region branches, and call handling.
Validation:
git diff --check