Felt review#1
Merged
Merged
Conversation
- lake-manifest.json: re-resolved (lake update) to the lakefile pin project-llzk/veir @ 09d5f00f0. The committed manifest had pointed at a stale personal-fork rev (alexanderlhicks/veir @ bf086362), 3 commits behind and predating the FeltConstAttr parser fix — so a plain `lake build` built the wrong proof basis. - docs/REVIEW.md: independent review of the llzk-lean bridge (Strategy A/E): the three-joint assurance-gap analysis with #print axioms evidence, the C/H/M/L findings catalog, the salvage verdict, and the structural-close result (2 of 15 Felt patterns now verified sorry-free + axiom-clean upstream in veir). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The 15 Felt rewrite patterns + the felt-combine pass no longer carry sorryAx: all rewriter preconditions discharged in veir's RewriteLemmas.lean (F1, commit 3fb22d4fc / 410ceae7c). Updated the §2 baseline table, the §3 central-finding axiom diagram + joint 2, C1, and M1. Joints 1 (theorem↔pattern by naming) and 3 (no algebra↔interpreter bridge) remain open: "verified" now means arithmetic identity + IR well-formedness, still not semantic preservation. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.