Fix account issues + qb-management export support#10
Open
Millusion wants to merge 3 commits intoproject-error:mainfrom
Open
Fix account issues + qb-management export support#10Millusion wants to merge 3 commits intoproject-error:mainfrom
Millusion wants to merge 3 commits intoproject-error:mainfrom
Conversation
Contributor
|
is this tested and working @RoccoMyTacco @Millusion |
Contributor
uh last time I tested it, it worked fine but I didnt test too much Was also waiting for this to get done project-error/pefcl#98 |
Author
|
for now on my local dev build i have no issues with this |
Mkeefeus
reviewed
Oct 27, 2022
Mkeefeus
left a comment
Mkeefeus
left a comment
There was a problem hiding this comment.
reason wasn't showing in the UI when I tried it, looks like the arg name was wrong
| local data = { | ||
| identifier = account, | ||
| amount = amount, | ||
| description = reason |
There was a problem hiding this comment.
Suggested change
| description = reason | |
| message = reason |
Mkeefeus
reviewed
Oct 30, 2022
|
you are a god, u just fixed everything for me! |
Co-authored-by: Malcolm Keefe <27903055+Mkeefeus@users.noreply.github.com>
Co-authored-by: Malcolm Keefe <27903055+Mkeefeus@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no idea why he is not merging this in...so i'm doing it