Conversation
|
One problem I just thought about will be groups that were created before this and don't have the "createdBy" defined, I could make it so any groups that don't have that will allow any member to remove another member. I also don't know if any errors will be created if "createdBy" is left blank |
|
Tested with no createBy date, everything still works however no one can remove people (may add it so everyone can remove in the future). Also just added leaving groups |
LiamDormon
left a comment
There was a problem hiding this comment.
Looks good so far, only issue I have is that members cannot re-join a group and a few minor things
TasoOneAsia
left a comment
There was a problem hiding this comment.
There are a couple small things I noticed that might need some cleanup but all in all good work, thank you for the PR :)
phone/src/apps/messages/components/form/NewMessageGroupForm.tsx
Outdated
Show resolved
Hide resolved
|
Just need to do some last testing but this should be finished, @Mojito-Fivem would you prefer I do a separate PR for adding members to groups or keep it here |
|
It's all under the same feature and I think it would create more issues having this without the adding members functionality |
|
Added system messages The following SQL is now needed (added to the original message) ALTER TABLE npwd_messages ADD COLUMN `is_system` tinyint(4) NOT NULL DEFAULT 0;
ALTER TABLE npwd_messages ADD COLUMN `system_type` varchar(48) NOT NULL DEFAULT '';
ALTER TABLE npwd_messages ADD COLUMN `system_number` varchar(48) NOT NULL DEFAULT ''; |
|
Will there not be any chance of group calling? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
this needs to be revived 😢 |
|
i have an idea. the owner can close the chat and only the owner him self can send message, or create a bol for chat user that can send message to chat. |

Pull Request Description
A full rework of the group system
Feature Specs:
Tasks Progress:
Preview
The following SQL needs to be ran
#610
Pull Request Checklist: