feat: adicionado suporte ao r2#1151
Open
HugoSilvaF wants to merge 5 commits intoproject-error:masterfrom
Open
Conversation
Author
|
I am waiting the approval. |
Member
|
Hey @HugoSilvaF ! Awesome PR! I'll have a look! Would be great if you could also update the docs with this guide! |
itschip
requested changes
May 20, 2024
Comment on lines
+32
to
+33
| accessKeyId: config.images.r2.credentials.accessKeyId, | ||
| secretAccessKey: config.images.r2.credentials.secretAccessKey |
Member
There was a problem hiding this comment.
These should not be in the config. We should get these from Convars not exposed to client.
Comment on lines
+48
to
52
| "dependencies": { | ||
| "@aws-sdk/client-s3": "^3.574.0", | ||
| "aws-sdk": "^2.1618.0" | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Please install these the correct package.json file. We are using turborepo, so you can install these deps in the game package like this
pnpm --filter @npwd/game add .... from the root dir.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
I changed config.json, ResourceConfig interface, http-service.
I have added supports to Cloudflare R2 to upload images.
IMGUR doesnt works anymore, so i have added another option.
To r2 works, need the public link in
In url needs the public url the r2
your config
you need access cloudflare and create an account and a public r2 bucket
https://dash.cloudflare.com/
after created your account you need go to the r2 overiew
after this, you need create an bucket
after created your bucket go to the settings and get a public url
getting a public url
Pull Request Checklist: