feat(apps/phone): when creating a conversation, redirect to it if exists#1066
Open
GiroudMathias wants to merge 3 commits intoproject-error:masterfrom
Open
feat(apps/phone): when creating a conversation, redirect to it if exists#1066GiroudMathias wants to merge 3 commits intoproject-error:masterfrom
GiroudMathias wants to merge 3 commits intoproject-error:masterfrom
Conversation
GiroudMathias
commented
Sep 20, 2023
Author
GiroudMathias
left a comment
GiroudMathias
left a comment
There was a problem hiding this comment.
On message, search user with number or contact name
itschip
requested changes
Sep 20, 2023
| return resp({ | ||
| status: 'error', | ||
| errorMsg: 'MESSAGES.FEEDBACK.MESSAGE_CONVERSATION_DUPLICATE', | ||
| data: { id: await this.messagesDB.getConversationId(conversationList) } |
Member
There was a problem hiding this comment.
Please follow the pattern and call async function outside of the resp function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Somes changes and optimisations:
Pull Request Checklist: