Notifications: Add sound option to generic useNotification hook and code cleanup#1023
Open
BackSH00TER wants to merge 2 commits intoproject-error:masterfrom
Open
Notifications: Add sound option to generic useNotification hook and code cleanup#1023BackSH00TER wants to merge 2 commits intoproject-error:masterfrom
BackSH00TER wants to merge 2 commits intoproject-error:masterfrom
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Problem: When a user receives a notification, the alert does not play a sound effect.
I found that each app had its own implementation of a useAppNameNotification hook (ex: useMessageNotifications), that did have a sound option built in. I followed up with Chip in discord and he confirmed these hooks were from a previous older notification system and that they moved to a more generic approach using a single
useNotificationhook.As such this PR does two things:
useNotificationhook to take a new parameterplaySoundanyso I added specific types for these so its more clear on the expected shape of the optionsPull Request Checklist: