-
Notifications
You must be signed in to change notification settings - Fork 56
feat(RHOAIENG-26487): Cluster lifecycling via RayJob #873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(RHOAIENG-26487): Cluster lifecycling via RayJob #873
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ray-jobs-feature #873 +/- ##
====================================================
+ Coverage 93.06% 93.67% +0.61%
====================================================
Files 28 31 +3
Lines 1513 1724 +211
====================================================
+ Hits 1408 1615 +207
- Misses 105 109 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
486a6bd
to
0add890
Compare
/hold |
9a01141
to
0add890
Compare
/retest |
I've verified this change works as described |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some requested changes for reference @chipspeak. I also left random reminders for myself when I finish this PR off next week.
cc: @LilyLinh
0a32a85
to
df435d8
Compare
fb35efb
to
6585567
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: Pat's changes were tested by myself and @laurafitzgerald & reviewed by me, and my changes were tested and reviewed by @chipspeak
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kryanbeane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
3228739
into
project-codeflare:ray-jobs-feature
Issue link
Jira
What changes have been made
Support has been added to submit a RayJob that will create and lifecycle its own cluster.
Verification steps
Prerequisites
poetry build
oc login
Steps
poetry build
.Checks