Updates TC-GRPKEY-2.2 as per Test Plan Changes #39342
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the TC-GRPKEY-2.2 test case. The label for Step 1 has been slightly modified, and a new Step 26 has been added to remove group key sets. The changes seem to align with the objective of updating the test script based on test plan modifications. I have a few suggestions to improve the clarity and consistency of the new test step.
Summary of Findings
- Verification Block Verbosity: The verification instructions and sample logs in the new Step 26 are repeated, making the section verbose. A more concise presentation is suggested.
- UserPrompt Clarity: The UserPrompt message in the new Step 26 could be more specific about what constitutes "success" when multiple actions are performed.
- Missing Trailing Newline: The file
Test_TC_GRPKEY_2_2.yamlwill not end with a newline after these changes, which is inconsistent with other YAML files in the repository and general text file conventions.
Merge Readiness
The pull request addresses the necessary updates to the test script. However, there are a few areas for improvement regarding clarity, conciseness, and file formatting consistency. I recommend addressing the medium severity issues identified in the review comments before merging. As an AI, I am not authorized to approve pull requests; please ensure further review and approval by authorized team members.
|
PR #39342: Size comparison from 4ad04a2 to 37d7110 Increases above 0.2%:
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #39342: Size comparison from 9f02498 to 8bd3fe2 Increases above 0.2%:
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #39342: Size comparison from bce7d27 to bd604b7 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
As per latest conversation with @Ashwinigrl, this script is to be ported over to Python. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
Updates TC-GRPKEY-2.2 as per Test Plan Changes
Addresses:
[TC-GRPKEY-2.2] Script has to be updated as per Test Plan #349