Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

registry: Avoid calling Value.setValue() when closing registry #1601

Merged
merged 2 commits into from
Oct 23, 2024
Merged

registry: Avoid calling Value.setValue() when closing registry #1601

merged 2 commits into from
Oct 23, 2024

Conversation

BlankEclair
Copy link
Contributor

Fixes #1349

progval
progval reviewed Oct 22, 2024
View reviewed changes
src/registry.py Outdated Show resolved Hide resolved
@progval
Copy link
Owner

progval commented Oct 23, 2024

Thanks for the repro, troubleshooting, and the PR! That was very helpful

@progval progval merged commit 8ec8730 into progval:master Oct 23, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@progval progval progval left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

protocols.http.proxy occassionally gets ignored
2 participants
@BlankEclair @progval