Skip to content

sh1pt: install Node pnpm Test (node-pnpm-test@1.0.0) - #399

Merged
ralyodio merged 2 commits into
masterfrom
sh1pt/actions/node-pnpm-test/20260604-212920
Jun 4, 2026
Merged

sh1pt: install Node pnpm Test (node-pnpm-test@1.0.0)#399
ralyodio merged 2 commits into
masterfrom
sh1pt/actions/node-pnpm-test/20260604-212920

Conversation

@sh1pt-actions-fleet

Copy link
Copy Markdown
Contributor

sh1pt Actions Fleet: install Node pnpm Test

Installs Node pnpm Test (node-pnpm-test@1.0.0) from the sh1pt Actions Store.

Files

  • .github/workflows/test.yml — create

Required secrets

No new secrets required.

Notes

  • Generated workflow files include a managed comment with a sha256 of the rendered body, so future updates can be detected without overwriting hand-edits.
  • Install mode: pull request (no direct commits).
  • Rollback: close this PR or revert the merge commit.

Generated by sh1pt Actions Fleet.

@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown

vu1nz Security Review

0 finding(s) in PR #?

No security issues found.

@greptile-apps

greptile-apps Bot commented Jun 4, 2026

Copy link
Copy Markdown

Greptile Summary

This PR adds a new .github/workflows/test.yml workflow generated by the sh1pt Actions Fleet, which runs pnpm install and pnpm test on every pull request and push to master.

  • The new workflow duplicates the test execution already performed in ci.yml, which runs the same pnpm install --frozen-lockfile and pnpm test steps on identical trigger events — meaning every CI run now executes tests twice.
  • ci.yml additionally runs pnpm type-check before the tests, so type errors will still be caught by CI even though this new workflow omits that step.

Confidence Score: 4/5

Safe to merge from a correctness standpoint — tests will still run and nothing will break — but the workflow duplicates work already done by ci.yml on every PR and master push.

The new workflow introduces no broken steps and the CI environment is otherwise sound, but it unconditionally doubles test execution time on every trigger event by running the same steps that ci.yml already runs. The missing concurrency group means rapid pushes can also stack up multiple parallel runs of this workflow with no automatic cancellation.

.github/workflows/test.yml warrants a second look given its overlap with the existing ci.yml.

Important Files Changed

Filename Overview
.github/workflows/test.yml New workflow that duplicates pnpm test execution already covered by ci.yml; missing concurrency cancellation and uses a hard-pinned pnpm version inconsistent with ci.yml's floating major-version pin.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Push to master or Pull Request] --> B[ci.yml triggered]
    A --> C[test.yml triggered - NEW]

    B --> B1[checkout]
    B1 --> B2[pnpm setup v9]
    B2 --> B3[setup-node 22]
    B3 --> B4[pnpm install frozen]
    B4 --> B5[pnpm type-check]
    B5 --> B6[pnpm test]

    C --> C1[checkout]
    C1 --> C2[pnpm setup v9.12.0]
    C2 --> C3[setup-node 22]
    C3 --> C4[pnpm install frozen]
    C4 --> C5[pnpm test - duplicate]

    style C fill:#ffe0e0,stroke:#cc0000
    style C5 fill:#ffe0e0,stroke:#cc0000
Loading

Reviews (2): Last reviewed commit: "Merge remote-tracking branch 'origin/mas..." | Re-trigger Greptile

Comment on lines +6 to +10

on:
pull_request:
push:
branches: [master]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Overlapping triggers with existing ci.yml

The existing .github/workflows/ci.yml already runs pnpm install --frozen-lockfile and pnpm test on every pull_request and on push to master. This new workflow duplicates those exact steps for the same trigger events, so every PR and every master push will now run pnpm test twice in parallel, consuming double the CI minutes with no additional coverage.

Comment on lines +15 to +18
jobs:
test:
runs-on: ubuntu-latest
timeout-minutes: 15

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Missing concurrency group

The existing ci.yml cancels in-progress runs with a concurrency group, so redundant queued runs are cleaned up automatically. Without this, rapid pushes or frequent PR updates will stack up multiple test workflow runs simultaneously.

Suggested change
jobs:
test:
runs-on: ubuntu-latest
timeout-minutes: 15
concurrency:
group: test-${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
jobs:
test:
runs-on: ubuntu-latest
timeout-minutes: 15

Comment on lines +22 to +24
- uses: pnpm/action-setup@v4
with:
version: 9.12.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Inconsistent pnpm version with ci.yml

ci.yml uses version: 9 (tracks the latest 9.x patch automatically), while this workflow hard-pins to 9.12.0. When pnpm 9.x releases bug or security fixes, ci.yml picks them up but test.yml stays behind, making the two environments subtly differ.

Suggested change
- uses: pnpm/action-setup@v4
with:
version: 9.12.0
- uses: pnpm/action-setup@v4
with:
version: 9

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@ralyodio
ralyodio merged commit 63de7df into master Jun 4, 2026
6 checks passed
@ralyodio
ralyodio deleted the sh1pt/actions/node-pnpm-test/20260604-212920 branch June 4, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant