Skip to content

fix: send invite emails before inserting DB records to avoid partial-state bugs #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ralyodio merged 1 commit into from
May 29, 2026
Merged

fix: send invite emails before inserting DB records to avoid partial-state bugs #303

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 22 additions & 11 deletions src/app/api/referrals/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,26 @@ export async function POST(request: NextRequest) {
);
}

const referralRows = newValidEmails.map((email: string) => ({
// Send emails BEFORE inserting into DB to avoid partial-state issues
const emailContent = referralInviteEmail({ inviterName, referralCode });
const emailResults = await Promise.all(
newValidEmails.map((email: string) =>
sendEmail({ to: email, ...emailContent })
)
);

const successfulEmails = newValidEmails.filter((_, i) => emailResults[i]?.success);
const failedEmailCount = emailResults.filter((r) => !r.success).length;

if (successfulEmails.length === 0) {
return NextResponse.json(
{ error: "Failed to send invitation emails. Please try again." },
{ status: 502 }
);
}

// Only insert DB records for successfully delivered emails
const referralRows = successfulEmails.map((email: string) => ({
referrer_id: user.id,
referred_email: email.trim().toLowerCase(),
referral_code: referralCode,
Expand All @@ -170,18 +189,10 @@ export async function POST(request: NextRequest) {
return NextResponse.json({ error: error.message }, { status: 400 });
}

const emailContent = referralInviteEmail({ inviterName, referralCode });
const emailResults = await Promise.all(
newValidEmails.map((email: string) =>
sendEmail({ to: email, ...emailContent })
)
);
const failedEmailCount = emailResults.filter((result) => !result.success).length;

return NextResponse.json({
message: failedEmailCount > 0
? `${newValidEmails.length} invite(s) created; ${failedEmailCount} email(s) failed to send`
: `${newValidEmails.length} invite(s) created and sent`,
? `${successfulEmails.length} invite(s) sent successfully; ${failedEmailCount} email(s) failed`
: `${successfulEmails.length} invite(s) sent successfully`,
data: referrals,
email_delivery_failed: failedEmailCount,
});
Expand Down
Loading