Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 55 additions & 0 deletions apps/extension/__tests__/options-app.test.jsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
import React from 'react';
import { beforeEach, describe, expect, it, vi } from 'vitest';
import { fireEvent, render, screen, waitFor } from '@testing-library/react';

import App from '../src/options/App.jsx';

describe('extension options app', () => {
beforeEach(() => {
global.chrome = {
alarms: {
create: vi.fn().mockResolvedValue(undefined),
},
storage: {
local: {
get: vi.fn((keys, callback) => callback({})),
set: vi.fn().mockResolvedValue(undefined),
},
},
};
});

it('normalizes a blank scan interval and reschedules the alarm on save', async () => {
render(<App />);

const intervalInput = screen.getByLabelText(/event check interval/i);
fireEvent.change(intervalInput, { target: { value: '' } });
fireEvent.click(screen.getByRole('button', { name: /save settings/i }));

await waitFor(() => {
expect(chrome.storage.local.set).toHaveBeenCalledWith(
expect.objectContaining({ scanInterval: 5 })
);
});
expect(chrome.alarms.create).toHaveBeenCalledWith('threatcrush-event-check', {
periodInMinutes: 5,
});
});

it('persists the selected scan interval and applies it to the event alarm', async () => {
render(<App />);

const intervalInput = screen.getByLabelText(/event check interval/i);
fireEvent.change(intervalInput, { target: { value: '15' } });
fireEvent.click(screen.getByRole('button', { name: /save settings/i }));

await waitFor(() => {
expect(chrome.storage.local.set).toHaveBeenCalledWith(
expect.objectContaining({ scanInterval: 15 })
);
});
expect(chrome.alarms.create).toHaveBeenCalledWith('threatcrush-event-check', {
periodInMinutes: 15,
});
});
});
36 changes: 31 additions & 5 deletions apps/extension/src/options/App.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,20 @@ const DEFAULT_SETTINGS = {
scanInterval: 5,
};

const MIN_SCAN_INTERVAL = 1;
const MAX_SCAN_INTERVAL = 60;
const EVENT_CHECK_ALARM = 'threatcrush-event-check';

function normalizeScanInterval(value) {
const parsed = Number.parseInt(value, 10);

if (!Number.isFinite(parsed)) {
return DEFAULT_SETTINGS.scanInterval;
}

return Math.min(MAX_SCAN_INTERVAL, Math.max(MIN_SCAN_INTERVAL, parsed));
}

export default function App() {
const [settings, setSettings] = useState(DEFAULT_SETTINGS);
const [saved, setSaved] = useState(false);
Expand All @@ -21,7 +35,16 @@ export default function App() {

async function handleSave(e) {
e.preventDefault();
await chrome.storage.local.set(settings);
const nextSettings = {
...settings,
scanInterval: normalizeScanInterval(settings.scanInterval),
};

await chrome.storage.local.set(nextSettings);
await chrome.alarms.create(EVENT_CHECK_ALARM, {
periodInMinutes: nextSettings.scanInterval,
});
setSettings(nextSettings);
setSaved(true);
setTimeout(() => setSaved(false), 2000);
}
Expand All @@ -48,8 +71,9 @@ export default function App() {

<div className="space-y-3">
<div>
<label className="block text-xs text-gray-400 mb-1">Server URL</label>
<label htmlFor="server-url" className="block text-xs text-gray-400 mb-1">Server URL</label>
<input
id="server-url"
type="url"
value={settings.serverUrl}
onChange={(e) => updateSetting('serverUrl', e.target.value)}
Expand All @@ -58,8 +82,9 @@ export default function App() {
</div>

<div>
<label className="block text-xs text-gray-400 mb-1">License Key</label>
<label htmlFor="license-key" className="block text-xs text-gray-400 mb-1">License Key</label>
<input
id="license-key"
type="password"
value={settings.licenseKey}
onChange={(e) => updateSetting('licenseKey', e.target.value)}
Expand Down Expand Up @@ -105,15 +130,16 @@ export default function App() {
</label>

<div>
<label className="block text-xs text-gray-400 mb-1">
<label htmlFor="scan-interval" className="block text-xs text-gray-400 mb-1">
Event check interval (minutes)
</label>
<input
id="scan-interval"
type="number"
min="1"
max="60"
value={settings.scanInterval}
onChange={(e) => updateSetting('scanInterval', parseInt(e.target.value, 10))}
onChange={(e) => updateSetting('scanInterval', e.target.value)}
className="w-24 px-3 py-2 bg-[#0a0a0a] border border-[#222] rounded-lg text-sm text-white focus:outline-none focus:border-[#00ff41] transition-colors"
/>
</div>
Expand Down
Loading