fix(code-scanner): close the same TOCTOU gap in sast - #53
Merged
Conversation
The secrets subsystem's stat-then-read gap was fixed in #52; sast had the identical pattern and CodeQL flagged it on the next scan. Same fix: one file handle for the size check and the read, so the bytes analysed are the bytes measured. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
vu1nz Security Review0 finding(s) in PR #? No security issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #52.
The
secretssubsystem'sstat(path)→readFile(path)gap was fixed there;sasthad the identical pattern and CodeQL flagged it on the next scan of master.Same fix: one file handle for the size check and the read, so the bytes analysed are the bytes measured. A path can be swapped between a separate stat and read, which on a host where an attacker can write to a scanned directory is a way to feed the scanner something other than what it approved.
90 tests, build clean.