Skip to content

fix(pypi): keep upload token out of argv - #985

Merged
ralyodio merged 1 commit into
profullstack:masterfrom
WNZhao:fix/pypi-token-env
Aug 28, 2026
Merged

fix(pypi): keep upload token out of argv#985
ralyodio merged 1 commit into
profullstack:masterfrom
WNZhao:fix/pypi-token-env

Conversation

@WNZhao

@WNZhao WNZhao commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • authenticate Twine through its supported TWINE_USERNAME and TWINE_PASSWORD environment variables
  • stop putting the PyPI API token in process arguments
  • add a regression test asserting the secret is absent from argv

Twine documents environment variables as its CI-friendly credential mechanism. Keeping the token out of argv avoids exposure through process inspection and captured command errors.

Verification

  • pnpm exec vitest run packages/targets/sdk-pypi/src/index.test.ts (2/2)
  • pnpm --filter @profullstack/sh1pt-target-sdk-pypi typecheck
  • git diff --check

expect(args).not.toContain('--password');
expect(options.env).toMatchObject({
TWINE_USERNAME: '__token__',
TWINE_PASSWORD: 'pypi-secret-token',
@github-actions

Copy link
Copy Markdown

🤖 Auto-rebase: The branch was rebased successfully locally but could not be pushed to the fork. Please enable 'Allow edits from maintainers' in the PR settings, or rebase manually: git fetch upstream master && git rebase upstream/master.

5 similar comments
@github-actions

Copy link
Copy Markdown

🤖 Auto-rebase: The branch was rebased successfully locally but could not be pushed to the fork. Please enable 'Allow edits from maintainers' in the PR settings, or rebase manually: git fetch upstream master && git rebase upstream/master.

@github-actions

Copy link
Copy Markdown

🤖 Auto-rebase: The branch was rebased successfully locally but could not be pushed to the fork. Please enable 'Allow edits from maintainers' in the PR settings, or rebase manually: git fetch upstream master && git rebase upstream/master.

@github-actions

Copy link
Copy Markdown

🤖 Auto-rebase: The branch was rebased successfully locally but could not be pushed to the fork. Please enable 'Allow edits from maintainers' in the PR settings, or rebase manually: git fetch upstream master && git rebase upstream/master.

@github-actions

Copy link
Copy Markdown

🤖 Auto-rebase: The branch was rebased successfully locally but could not be pushed to the fork. Please enable 'Allow edits from maintainers' in the PR settings, or rebase manually: git fetch upstream master && git rebase upstream/master.

@github-actions

Copy link
Copy Markdown

🤖 Auto-rebase: The branch was rebased successfully locally but could not be pushed to the fork. Please enable 'Allow edits from maintainers' in the PR settings, or rebase manually: git fetch upstream master && git rebase upstream/master.

@ralyodio
ralyodio merged commit 729d00e into profullstack:master Aug 28, 2026
6 checks passed
@github-actions

Copy link
Copy Markdown

🤖 Auto-rebase: The branch was rebased successfully locally but could not be pushed to the fork. Please enable 'Allow edits from maintainers' in the PR settings, or rebase manually: git fetch upstream master && git rebase upstream/master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants