fix(sdk-pypi): allow dry-run without token - #954
Merged
ralyodio merged 1 commit intoAug 12, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduction
On current
master, calladapter.ship(fakeShipContext({ dryRun: true, secret: () => undefined }), {}). Instead of returning the dry-run preview,sdk-pypirejects withPYPI_TOKEN not setbecause it reads and validates the token before checkingctx.dryRun. It therefore cannot preview a PyPI upload without credentials, unlike the other target adapters’ side-effect-free dry-run behavior.Fix
Resolve the repository and return the existing dry-run result before reading
PYPI_TOKEN. Real uploads still require the token and retain the same Twine arguments.Regression coverage
Added a focused test that supplies
dryRun: truewith an empty vault and verifies that:Verification:
corepack pnpm exec vitest run packages/targets/sdk-pypi/src/index.test.ts— 1 test passedcorepack pnpm --filter @profullstack/sh1pt-target-sdk-pypi typecheck— passedcorepack pnpm --filter @profullstack/sh1pt-target-sdk-pypi build— passedcorepack pnpm exec vitest run packages/targets— 67 files, 484 tests passed