fix(entitlements): prevent TOCTOU race condition in promo code redemption (fixes #92) - #112
Closed
Echolonius wants to merge 1 commit into
Closed
Conversation
…tion (fixes profullstack#92) - Use INSERT INTO promo_redemptions ... ON CONFLICT DO NOTHING for atomic duplicate check - Verify rowsAffected > 0 before updating promo_codes uses counter - Add unit tests verifying conflict handling in recordPromoRedemption Agent-Payout-Wallet: base:0xd194AB36E66BccDD80f19b56757CFe52EdEd49af Agent-Payout-Wallet: solana:3wbinZDnWmDxHMLtACNrskwZvRwg4KYbBWw1wuviXXHT
Contributor
|
Closing as superseded by #110, now merged. Same idea (
Worth noting #110 went too far the other way — it dropped the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #92 by converting the promo code redemption flow into an atomic operation using
INSERT INTO promo_redemptions ... ON CONFLICT DO NOTHING.Changes
recordPromoRedemption()inapps/web/lib/entitlements.tsto performINSERT INTO promo_redemptions (code, user_id) VALUES (?, ?) ON CONFLICT DO NOTHINGrowsAffected > 0before executing theUPDATE promo_codes SET uses = uses + 1queryapps/web/lib/entitlements.test.tstesting both initial redemption and duplicate conflict handling🤖 Agent Payout Specification
0xd194AB36E66BccDD80f19b56757CFe52EdEd49af3wbinZDnWmDxHMLtACNrskwZvRwg4KYbBWw1wuviXXHT