Skip to content

Conversation

@mingness
Copy link
Collaborator

  • move definition of prettyVersion to properties file.
  • move version definition in build file to outside of section designated for users to define
  • move reading in of properties file earlier, so its value of prettyVersion can be used to define version

@github-actions
Copy link

github-actions bot commented Mar 29, 2025

PR Preview Action v1.6.0
Preview removed because the pull request was closed.
2025-04-02 14:14 UTC

@mingness mingness linked an issue Mar 29, 2025 that may be closed by this pull request
@SableRaf SableRaf self-requested a review March 31, 2025 09:25
@SableRaf
Copy link
Collaborator

Hey @mingness thanks for these updates!

In release.properties, I'd suggest adding a comment to mention the fact that this property may be overwritten by a GitHub release tag.

Something like this:

// Note: The prettyVersion value defined here can be overwritten by a GitHub release tag. 
// If a release tag is present, the numeric part of the tag will be used as the version number.
// See docs/release.md for more details.

@mingness
Copy link
Collaborator Author

@SableRaf thanks, good suggestion - it is now there.

@mingness mingness merged commit 76400b4 into main Apr 2, 2025
1 check passed
@mingness mingness deleted the one-properties-file branch April 2, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

version numbers in 1 file

3 participants