Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed deployToProcessingSketchbook #75

Merged
merged 3 commits into from
Mar 29, 2025
Merged

Conversation

vincentsijben
Copy link
Contributor

@vincentsijben vincentsijben commented Mar 22, 2025

The copy action did not run properly. We had to run deployToProcessingSketchbook twice in order to copy the files properly to the local libraries folder.

Fixes #74 (Edit by @SableRaf)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
code wasn't correctly copying files.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Collaborator

@mingness mingness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one small change please.

@mingness mingness merged commit c952e0b into processing:main Mar 29, 2025
1 check failed
@vincentsijben
Copy link
Contributor Author

Looks great! Just one small change please.

I had added println("Copying fresh build to sketchbook $sketchbookLocation ...") so maybe now thats a bit too much?

@mingness
Copy link
Collaborator

ah, I understand your logic. In my mind, they serve different purposes, and therefore it's not too much. I already changed and merged though, so all good - hope that's ok.

@vincentsijben
Copy link
Contributor Author

ah, I understand your logic. In my mind, they serve different purposes, and therefore it's not too much. I already changed and merged though, so all good - hope that's ok.

haha sure! wasnt completely sure if you've overlooked that line. all good! thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

need to run deployToProcessingSketchbook twice
2 participants