Update zod 3 to zod 4 support in p5.js dev-2.0 #7872
Conversation
- line 325 schema `items` can be access within `def` - line 356 and 360 `_def` is deprecated , use `def` or directly use `options` - line 393 `zodErrorObj.errors[0]` changes to `zodErrorObj.errors[0]` - line 410 `union error` changes to `errors` - line 414 and 459 , `received` changes to `message` ## Important In constants.js, Symbols aren't considered literal values, nor can they be simply compared with ===. This was an oversight in Zod 3.
According to zod 4 , error message are more elaborated
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page! |
madhav2348
changed the title
|
Hi @madhav2348 ! Thanks for working on this. From the tests, looks like the zod update in package.json itself isn't part of the PR? |
My apologies, Thank you for figuring out. I was trying to reproduce the failed test case by switching back and forth between Zod 3 and Zod 4 versions to confirm which leads to uncommitted package.json changes. |
to match the test cases - split the error messages, to get a type in line 418 and 462 - `actualType` will never be undefined which is checked in line 394 so make it undefined in line 430 to pass all test cases
I went through the migration docs, but they haven't covered all the changes. The changes I made are by going through the source code of Zod 4. Thank you |
- z.function() is no longer a Zod schema. Instead, it acts as a standalone "function factory" for defining Zod-validated functions. - .def.type checks schema type. If its `'function'`, fallback to `z.any()`
Resolves #7833
Changes:
itemscan be accessed withindef_defis deprecated, usedefor directly useoptionszodErrorObj.errors[0]changes tozodErrorObj.issues[0]union errorchanges toerrorsreceivedchanges tomessageImportant
constant.js have some variable which are Symbols , according to zod 4, Symbols aren't considered literal values, nor can they be simply compared with ===. This was an oversight in Zod 3.
PR Checklist
npm run lintpasses