solving directionalLight reference error #7756
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page! |
limzykenneth
reviewed
May 2, 2025
There was a problem hiding this comment.
Thanks @Mamatha1718 I think I will merge #7777 and #7778 instead since they are ready and fixes both main and dev-2.0 branches. Feel free to checkout other open issues. Thanks again!
| * that shines from somewhere offscreen. The light’s direction is set using | ||
| * three `(x, y, z)` values between -1 and 1. For example, setting a light’s | ||
| * direction as `(1, 0, 0)` will light <a href="#/p5.Geometry">p5.Geometry</a> | ||
| * direction as `(1, 0, 0)` will light <a href="#/p5.Vector">p5.Vector</a> |
There was a problem hiding this comment.
I think this change is unintended? The sentence here don't really make sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7743
Changes:
Screenshots of the change:
PR Checklist
npm run lintpasses