-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Updating all the broken refrence examples. #7739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
perminder-17
wants to merge
30
commits into
processing:dev-2.0
Choose a base branch
from
perminder-17:patch-9
base: dev-2.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
81ff09d
updating computeFaces
perminder-17 77a1492
fixed vertexNormals
perminder-17 302e25b
vertices fixing
perminder-17 ade54ac
fixing
perminder-17 9df7595
fixing setAlpha
perminder-17 28cf83f
fixing-setGreen
perminder-17 5d2aad1
updating fontAscent
perminder-17 9e7445f
fixing @method pixels
perminder-17 12a6a17
fixing-getCurrentFrame()
perminder-17 8f017b0
fixing numFrames
perminder-17 eaedc0a
fixing setFrame()
perminder-17 2abbd76
fixing describe()
perminder-17 7b5d67c
fixing gridOutputs
perminder-17 c3851b3
fixing text-output
perminder-17 dac7ff2
fixing all p5.Camera text orientation
perminder-17 d19fefc
fixing setAttributes()
perminder-17 e4acb5f
fixing httpDo
perminder-17 9039796
fixing httpPost
perminder-17 63af24e
fixing print()
perminder-17 24763af
fixing getNum()
perminder-17 301d42f
Fixing rotationX(), rotationY() and rotationZ()
perminder-17 dd6a988
updating checkBox()
perminder-17 58e8746
createFileInput() orientation
perminder-17 25b164e
minor fixes
perminder-17 bf86b77
createElement fixes
perminder-17 289c176
fixing wording of setup() by removing preload
perminder-17 36b0bb0
fixing broken url
perminder-17 608d2fa
adding more context to docs
perminder-17 68dd3ae
reverting back to old p5.Geometry
perminder-17 cefb10b
Merge branch 'dev-2.0' into patch-9
perminder-17 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -81,6 +81,11 @@ function outputs(p5, fn){ | |
* | ||
* <div> | ||
* <code> | ||
* | ||
* function setup(){ | ||
* createCanvas(100, 100); | ||
* } | ||
* | ||
* function draw() { | ||
* // Add the text description. | ||
* textOutput(); | ||
|
@@ -101,6 +106,11 @@ function outputs(p5, fn){ | |
* | ||
* <div> | ||
* <code> | ||
* | ||
* function setup(){ | ||
* createCanvas(100, 100); | ||
* } | ||
* | ||
* function draw() { | ||
* // Add the text description and | ||
* // display it for debugging. | ||
|
@@ -215,6 +225,11 @@ function outputs(p5, fn){ | |
* | ||
* <div> | ||
* <code> | ||
* | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
* function setup() { | ||
* createCanvas(100, 100); | ||
* } | ||
* | ||
* function draw() { | ||
* // Add the grid description. | ||
* gridOutput(); | ||
|
@@ -235,6 +250,11 @@ function outputs(p5, fn){ | |
* | ||
* <div> | ||
* <code> | ||
* | ||
* function setup(){ | ||
* createCanvas(100, 100); | ||
* } | ||
* | ||
* function draw() { | ||
* // Add the grid description and | ||
* // display it for debugging. | ||
|
@@ -255,6 +275,7 @@ function outputs(p5, fn){ | |
* </div> | ||
*/ | ||
|
||
|
||
fn.gridOutput = function(display) { | ||
// p5._validateParameters('gridOutput', arguments); | ||
//if gridOutput is already true | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -142,18 +142,18 @@ function acceleration(p5, fn){ | |
* @example | ||
* <div> | ||
* <code> | ||
* let rotationX = 0; // Angle in degrees | ||
* | ||
* function setup() { | ||
* createCanvas(100, 100, WEBGL); | ||
* createCanvas(200, 200, WEBGL); // Create 3D canvas | ||
* } | ||
* | ||
* function draw() { | ||
* background(200); | ||
* //rotateZ(radians(rotationZ)); | ||
* rotateX(radians(rotationX)); | ||
* //rotateY(radians(rotationY)); | ||
* box(200, 200, 200); | ||
* describe(`red horizontal line right, green vertical line bottom. | ||
* black background.`); | ||
* background(220); // Set light gray background | ||
* rotateX(radians(rotationX)); // Rotate around X-axis | ||
* normalMaterial(); // Apply simple shaded material | ||
* box(60); // Draw 3D cube (60 units wide) | ||
* rotationX = (rotationX + 2) % 360; // Increment rotation (2° per frame) | ||
* } | ||
* </code> | ||
* </div> | ||
|
@@ -175,18 +175,18 @@ function acceleration(p5, fn){ | |
* @example | ||
* <div> | ||
* <code> | ||
* let rotationY = 0; // Angle in degrees | ||
* | ||
* function setup() { | ||
* createCanvas(100, 100, WEBGL); | ||
* createCanvas(200, 200, WEBGL); // Create 3D canvas | ||
* } | ||
* | ||
* function draw() { | ||
* background(200); | ||
* //rotateZ(radians(rotationZ)); | ||
* //rotateX(radians(rotationX)); | ||
* rotateY(radians(rotationY)); | ||
* box(200, 200, 200); | ||
* describe(`red horizontal line right, green vertical line bottom. | ||
* black background.`); | ||
* background(220); // Set light gray background | ||
* rotateY(radians(rotationY)); // Rotate around Y-axis (vertical) | ||
* normalMaterial(); // Apply simple shaded material | ||
* box(60); // Draw 3D cube (60 units wide) | ||
* rotationY = (rotationY + 2) % 360; // Increment rotation (2° per frame) | ||
* } | ||
* </code> | ||
* </div> | ||
|
@@ -209,18 +209,18 @@ function acceleration(p5, fn){ | |
* @example | ||
* <div> | ||
* <code> | ||
* let rotationZ = 0; // Angle in degrees | ||
* | ||
* function setup() { | ||
* createCanvas(100, 100, WEBGL); | ||
* createCanvas(200, 200, WEBGL); // Create 3D canvas | ||
* } | ||
* | ||
* function draw() { | ||
* background(200); | ||
* rotateZ(radians(rotationZ)); | ||
* //rotateX(radians(rotationX)); | ||
* //rotateY(radians(rotationY)); | ||
* box(200, 200, 200); | ||
* describe(`red horizontal line right, green vertical line bottom. | ||
* black background.`); | ||
* background(220); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice, thank you for the expanded example 👍 |
||
* rotateZ(radians(rotationZ)); // Rotate around Z-axis | ||
* normalMaterial(); // Apply simple shaded material | ||
* box(60); // Draw 3D cube | ||
* rotationZ = (rotationZ + 2) % 360; // Increment rotation angle | ||
* } | ||
* </code> | ||
* </div> | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ksen0 , are these functions still broken on my branch as well i.e. After this PR?. I think I tried fixing textOutput() and gridOutput here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect there's bigger problems here because they're broken on 1.x and 2.0. I'll make a separate 1.x/2.0 issue tomorrow about it, please feel free to ignore for this PR. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, So sorry for the oversight, I think the sketch works correctly but it didn't shows up correctly in the website. I'll have a look today late night or tomorrow morning to figure out what's going on. Thanks for the patience @ksen0 :)