Add custom_shapes.js, which will eventually replace vertex.js #7368
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #6560
Changes:
This is a small PR that just sets up a new file, with the following changes:
This was originally intended as a draft PR so that I could continue adding features, but I accidentally messed up the two commit messages. So I'm thinking maybe this PR can be squashed and merged, with the PR title as the commit message? Then I can submit a new PR with any additions?
Note:
Once we're ready to remove the old implementation, I propose that we keep the file name custom_shapes.js (instead of vertex.js) and use the same name for the submodule, so that "Custom Shapes" appears as a heading in the reference instead of "Vertex." The new name is general enough to encompass all the functions it contains, while also being more descriptive for beginners. The phrase "custom shapes" already appears in descriptions of the relevant functions as well, so it's consistent with existing reference descriptions.
PR Checklist
npm run lint
passes