fixed reference classes don't show up in filter search #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davepagurek
reviewed
Apr 11, 2025
There was a problem hiding this comment.
Thanks @webermayank! The functionality looks great! I just left some minor comments to try to make the formatting consistent with the rest of the codebase.
| const filteredEntries = subcat.entries.filter((entry) => | ||
| entry.data.title | ||
| .toLowerCase() | ||
| .includes(searchKeyword.toLowerCase()), | ||
| ); | ||
| if (subcat.entry && |
There was a problem hiding this comment.
Could we format this like the brackets in this section, where the parts in the brackets are indented in once? e.g.:
if (
condition1 &&
condition2
) {
doSomething(); // code here, indented in once too
}Currently, I the spacing in the if condition is a tad inconsistent, and the body of the if statement is indented with just one space instead of two.
Co-authored-by: Dave Pagurek <[email protected]>
|
@davepagurek , is it okay now ? |
davepagurek
approved these changes
Apr 11, 2025
|
Also no worries about code formatting, it's not super important, just a nice thing to have if everything else works 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #717
earlier classes was not showing in filer search, after i modified the code and added a check , classes comes up in filter search
more example
@ksen0 , @davepagurek - please verify if this is correct. Tell me if something needs to be changed