Multiple p5.sound references pages are broken fixed and page render speed enhanced #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple p5.sound references pages are broken fixed and page render speed enhanced
|
Hi @Sanjai-Shaarugesh , could you explain please what your intent with this PR is? It is not related to the p5.sound bug that was referenced; also there is no current approved solution to the p5.sound.js bug, so please hold off writing code before the discussion is concluded (you're welcome to discuss on the issue). Did you mean to link to some other issue? Thanks! |
|
Closing this PR as it is unclear what it's resolving besides the p5.sound links; regarding the p5.sound links, this PR will resolve the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#746
Multiple p5.sound references pages are broken fixed and page render speed enhanced