Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #696 #701

Closed
wants to merge 3 commits into from
Closed

Fixes issue #696 #701

wants to merge 3 commits into from

Conversation

riteshsp2000
Copy link
Contributor

@riteshsp2000 riteshsp2000 commented Apr 15, 2020

Fixes #696

Changes:
The changes are mentioned in the issue #696
Along with those changes, some code factoring is done so that all the code related to responsiveness in the file main.css is in one place. Earlier the code for responsiveness of sidebar was way at the top of the file.

@limzykenneth
Copy link
Member

@riteshsp2000 I'm a bit tied up at the moment to test it locally so bear with me while I find some time in the next few days to review this. In the meantime, can you revert the changes to reference.js and reference.js.map that is not related to this PR? Thanks.

@riteshsp2000
Copy link
Contributor Author

yes, ill revert the changes. Actually, when I pulled for the upstream, the changes were automatically implemented in those files. I didn't understand them then which is why I made the pull request. I'll revert them back now.

@limzykenneth
Copy link
Member

@riteshsp2000 You have deleted reference.js and reference.js.map from the repo in this PR, can you restore all changes to these files to match current master branch? Thanks.

@lmccart lmccart changed the base branch from master to main June 14, 2020 20:57
@lmccart
Copy link
Member

lmccart commented Jul 4, 2020

@riteshsp2000 I'm going to close this pull request so we can resolve the reference files issue. can you pull the latest from main, then create a new pull request adding only the files you've updated to make the change to resolve the issue? thanks!

@lmccart lmccart closed this Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Website non-responsive towards tablet views.
3 participants